[coreboot-gerrit] Patch merged into coreboot/master: cd24e3f lenovo/x60: Add "IBM ThinkPad Embedded Controller" SMBIOS OEM String
gerrit at coreboot.org
gerrit at coreboot.org
Wed Jul 17 17:15:26 CEST 2013
the following patch was just integrated into master:
commit cd24e3f6a7adecfc9d3b2a2dd2f81d84acffa91b
Author: Peter Stuge <peter at stuge.se>
Date: Sat Jul 6 20:10:36 2013 +0200
lenovo/x60: Add "IBM ThinkPad Embedded Controller" SMBIOS OEM String
The Linux thinkpad_acpi.c driver looks for this string while
reading information about the system it is running on.
This commit does not make the module load but it is one of
several things that the module looks for on a ThinkPad.
The use of 3 defines for the serial number template
seems odd but it's done in a way that eliminates
magic numbers, yet avoids use of strcpy, strlen,
strindex, strchr, or strspan: we can have some
correctness assured at compile time. Also, the
defines can be copy/pasted for other mainboards
and we should void errors due to people not changing
magic numbers.
Change-Id: Ief5f28d2e27bf959cb579c4c8eea9eecc9a89a7c
Signed-off-by: Peter Stuge <peter at stuge.se>
Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
Reviewed-on: http://review.coreboot.org/3620
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
See http://review.coreboot.org/3620 for details.
-gerrit
More information about the coreboot-gerrit
mailing list