[coreboot-gerrit] Patch set updated for coreboot: e8ba14f ec/kontron/it8516e: Correct fan setting for PWM mode

Nico Huber (nico.huber@secunet.com) gerrit at coreboot.org
Thu Jul 18 12:35:51 CEST 2013


Nico Huber (nico.huber at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3773

-gerrit

commit e8ba14fad2a60b78ec304a71ccc36bce114ed3d8
Author: Nico Huber <nico.huber at secunet.com>
Date:   Fri Jul 12 14:40:23 2013 +0200

    ec/kontron/it8516e: Correct fan setting for PWM mode
    
    The EC firmware expects a 255th while we provide a percentage.
    
    Change-Id: Ib06a061b431ac728329043179800729e39e6166b
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 src/ec/kontron/it8516e/ec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ec/kontron/it8516e/ec.c b/src/ec/kontron/it8516e/ec.c
index 7cf41d9..2cf4f90 100644
--- a/src/ec/kontron/it8516e/ec.c
+++ b/src/ec/kontron/it8516e/ec.c
@@ -118,7 +118,7 @@ static void it8516e_set_fan_from_options(const config_t *const config,
 		       "Setting it8516e fan%d "
 		       "control to %d%% PWM.\n",
 		       fan_idx + 1, fan_target);
-		it8516e_set_fan_pwm(fan_idx, fan_target);
+		it8516e_set_fan_pwm(fan_idx, (fan_target * 255) / 100);
 		break;
 	case IT8516E_MODE_SPEED:
 		printk(BIOS_DEBUG,



More information about the coreboot-gerrit mailing list