[coreboot-gerrit] New patch to review for filo: 8d6c592 Fix compilation of IDE driver
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Wed Jun 5 23:04:18 CEST 2013
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3378
-gerrit
commit 8d6c592f8cf5b53b96cdaf1cb8558a85252790b0
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date: Wed Jun 5 23:02:14 2013 +0200
Fix compilation of IDE driver
The FILO IDE driver was broken by recent changes in libpayload.
- CONFIG_LITTLE_ENDIAN is defined by libpayload's config.h
- The endian conversion macros have to be explicitly included
using #include <endian.h>
Signed-off-by: Stefan Reinauer <reinauer at google.com>
Change-Id: If0145b09ab1b64b040f46b9d39a3f9ab35be4a7e
---
drivers/hdreg.h | 3 ---
drivers/ide_new.c | 1 +
drivers/ide_new.h | 1 -
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/hdreg.h b/drivers/hdreg.h
index 6851fb7..eb4ff41 100644
--- a/drivers/hdreg.h
+++ b/drivers/hdreg.h
@@ -4,9 +4,6 @@
#ifndef HDREG_H
#define HDREG_H
#include <arch/types.h>
-//#include <misc.h>
-
-#define CONFIG_LITTLE_ENDIAN
#define u8 uint8_t
#define u16 uint16_t
diff --git a/drivers/ide_new.c b/drivers/ide_new.c
index 2e0965a..326430c 100644
--- a/drivers/ide_new.c
+++ b/drivers/ide_new.c
@@ -19,6 +19,7 @@
#include <config.h>
#include <fs.h>
+#include <endian.h>
#include "ide_new.h"
#include "hdreg.h"
diff --git a/drivers/ide_new.h b/drivers/ide_new.h
index 1956625..1d4dea0 100644
--- a/drivers/ide_new.h
+++ b/drivers/ide_new.h
@@ -230,7 +230,6 @@ int ob_ide_init(int driveno);
/* FILO compat */
-#define CONFIG_LITTLE_ENDIAN
#define CONFIG_IDE_LBA48
#endif
More information about the coreboot-gerrit
mailing list