[coreboot-gerrit] New patch to review for coreboot: 2488801 usbdebug: Quirk for board aopen/dxplplusu

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Thu Jun 6 14:20:33 CEST 2013


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3385

-gerrit

commit 2488801192d02da15fe086276b9da5010f82b10e
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Thu Jun 6 10:39:48 2013 +0300

    usbdebug: Quirk for board aopen/dxplplusu
    
    This ancient board with Intel e7505 invalidates cache while it does HW
    scrubbing for ECC in romstage. This breaks usbdebug console and prevents
    system from booting.
    
    If both EARLY_CONSOLE and USBDEBUG are selected, skip ECC scrubbing under
    these rare conditions to boot system.
    
    Change-Id: I6cb43bf69af54119f4a582dcaf498dd941d4c62d
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/aopen/dxplplusu/romstage.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/mainboard/aopen/dxplplusu/romstage.c b/src/mainboard/aopen/dxplplusu/romstage.c
index 9b96792..98701f9 100644
--- a/src/mainboard/aopen/dxplplusu/romstage.c
+++ b/src/mainboard/aopen/dxplplusu/romstage.c
@@ -70,9 +70,11 @@ void main(unsigned long bist)
 		 * scrub_ecc() are recovered to stack via xmm0-xmm3.
 		 */
 #if CONFIG_HW_SCRUBBER
+#if ! ( CONFIG_USBDEBUG && CONFIG_EARLY_CONSOLE )
 		unsigned long ret_addr = (unsigned long)((unsigned long*)&bist - 1);
 		e7505_mch_scrub_ecc(ret_addr);
 #endif
+#endif
 
 		/* Hook for post ECC scrub settings and debug. */
 		e7505_mch_done(memctrl);



More information about the coreboot-gerrit mailing list