[coreboot-gerrit] New patch to review for coreboot: 01b949a winbond/w83627dhg: Remove misleading uncommentation
Patrick Georgi (patrick@georgi-clan.de)
gerrit at coreboot.org
Thu Jun 6 14:26:41 CEST 2013
Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3391
-gerrit
commit 01b949a50d629ffb40189855919e42112f31f83c
Author: Nico Huber <nico.huber at secunet.com>
Date: Tue May 14 15:25:26 2013 +0200
winbond/w83627dhg: Remove misleading uncommentation
The current code isn't really able to hang at the given location, so
this old comment (and workaround) probably handle a bug that is gone
for a long time now.
Change-Id: I027d279b4641fecd88afb14d40fbe1c0bfbf81bb
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
src/superio/winbond/w83627dhg/superio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/superio/winbond/w83627dhg/superio.c b/src/superio/winbond/w83627dhg/superio.c
index bbde26a..66291ae 100644
--- a/src/superio/winbond/w83627dhg/superio.c
+++ b/src/superio/winbond/w83627dhg/superio.c
@@ -101,8 +101,7 @@ static struct pnp_info pnp_dev_info[] = {
{ &ops, W83627DHG_SP1, PNP_IO0 | PNP_IRQ0, {0x07f8, 0}, },
{ &ops, W83627DHG_SP2, PNP_IO0 | PNP_IRQ0, {0x07f8, 0}, },
{ &ops, W83627DHG_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1, {0x07ff, 0}, {0x07ff, 4}, },
- /* the next line makes coreboot hang in pnp_enable_devices() */
- /* { &ops, W83627DHG_SPI, PNP_IO1, { 0x7f8, 0 }, }, */
+ { &ops, W83627DHG_SPI, PNP_IO1, { 0x7f8, 0 }, },
{ &ops, W83627DHG_GPIO6, },
{ &ops, W83627DHG_WDTO_PLED, },
{ &ops, W83627DHG_GPIO2, },
More information about the coreboot-gerrit
mailing list