[coreboot-gerrit] Patch set updated for coreboot: cd9ed28 Make intel blob locations configurable

[Patrick Georgi (patrick@georgi-clan.de)]

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3453

-gerrit

commit cd9ed2823d469fbcfc446e414b0763d0b074e5e9
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Thu Jun 13 15:07:02 2013 +0200

    Make intel blob locations configurable
    
    They were hard-coded to be copied from 3rdparty/ which isn't always
    the right choice.
    
    Since the defaults stay the same, this should be compatible.
    
    Change-Id: If2173bef86ad1fcf2335e13472ea8ca41eb41f3d
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
---
 src/southbridge/intel/bd82x6x/Kconfig        | 8 ++++++++
 src/southbridge/intel/bd82x6x/Makefile.inc   | 4 ++--
 src/southbridge/intel/lynxpoint/Kconfig      | 8 ++++++++
 src/southbridge/intel/lynxpoint/Makefile.inc | 4 ++--
 4 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/src/southbridge/intel/bd82x6x/Kconfig b/src/southbridge/intel/bd82x6x/Kconfig
index 79c812e..08a60f9 100644
--- a/src/southbridge/intel/bd82x6x/Kconfig
+++ b/src/southbridge/intel/bd82x6x/Kconfig
@@ -72,6 +72,14 @@ config GBE_BIN_PATH
 	depends on HAVE_GBE_BIN
 	default "3rdparty/mainboard/$(MAINBOARDDIR)/gbe.bin"
 
+config ME_BIN_PATH
+	string "Path to management engine firmware"
+	default "3rdparty/mainboard/$(MAINBOARDDIR)/me.bin"
+
+config IFD_BIN_PATH
+	string "Path to intel firmware descriptor"
+	default "3rdparty/mainboard/$(MAINBOARDDIR)/descriptor.bin"
+
 config LOCK_MANAGEMENT_ENGINE
 	bool "Lock Management Engine section"
 	default n
diff --git a/src/southbridge/intel/bd82x6x/Makefile.inc b/src/southbridge/intel/bd82x6x/Makefile.inc
index 2e10e03..e277450 100644
--- a/src/southbridge/intel/bd82x6x/Makefile.inc
+++ b/src/southbridge/intel/bd82x6x/Makefile.inc
@@ -54,11 +54,11 @@ romstage-y += early_spi.c
 
 bd82x6x_add_me: $(obj)/coreboot.pre $(IFDTOOL)
 	printf "    DD         Adding Intel Firmware Descriptor\n"
-	dd if=3rdparty/mainboard/$(MAINBOARDDIR)/descriptor.bin \
+	dd if=$(CONFIG_IFD_BIN_PATH) \
 		of=$(obj)/coreboot.pre conv=notrunc >/dev/null 2>&1
 	printf "    IFDTOOL    me.bin -> coreboot.pre\n"
 	$(objutil)/ifdtool/ifdtool \
-		-i ME:3rdparty/mainboard/$(MAINBOARDDIR)/me.bin \
+		-i ME:$(CONFIG_ME_BIN_PATH) \
 		$(obj)/coreboot.pre
 	mv $(obj)/coreboot.pre.new $(obj)/coreboot.pre
 ifeq ($(CONFIG_HAVE_GBE_BIN),y)
diff --git a/src/southbridge/intel/lynxpoint/Kconfig b/src/southbridge/intel/lynxpoint/Kconfig
index f79e963..bd4f8d0 100644
--- a/src/southbridge/intel/lynxpoint/Kconfig
+++ b/src/southbridge/intel/lynxpoint/Kconfig
@@ -58,4 +58,12 @@ config SERIRQ_CONTINUOUS_MODE
 	  If you set this option to y, the serial IRQ machine will be
 	  operated in continuous mode.
 
+config ME_BIN_PATH
+	string "Path to management engine firmware"
+	default "3rdparty/mainboard/$(MAINBOARDDIR)/me.bin"
+
+config IFD_BIN_PATH
+	string "Path to intel firmware descriptor"
+	default "3rdparty/mainboard/$(MAINBOARDDIR)/descriptor.bin"
+
 endif
diff --git a/src/southbridge/intel/lynxpoint/Makefile.inc b/src/southbridge/intel/lynxpoint/Makefile.inc
index 7d1f894..8e65d55 100644
--- a/src/southbridge/intel/lynxpoint/Makefile.inc
+++ b/src/southbridge/intel/lynxpoint/Makefile.inc
@@ -63,11 +63,11 @@ endif
 
 lynxpoint_add_me: $(obj)/coreboot.pre $(IFDTOOL)
 	printf "    DD         Adding Intel Firmware Descriptor\n"
-	dd if=3rdparty/mainboard/$(MAINBOARDDIR)/descriptor.bin \
+	dd if=$(CONFIG_IFD_BIN_PATH) \
 		of=$(obj)/coreboot.pre conv=notrunc >/dev/null 2>&1
 	printf "    IFDTOOL    me.bin -> coreboot.pre\n"
 	$(objutil)/ifdtool/ifdtool \
-		-i ME:3rdparty/mainboard/$(MAINBOARDDIR)/me.bin \
+		-i ME:$(CONFIG_ME_BIN_PATH) \
 		$(obj)/coreboot.pre
 	mv $(obj)/coreboot.pre.new $(obj)/coreboot.pre
 ifeq ($(CONFIG_LOCK_MANAGEMENT_ENGINE),y)