[coreboot-gerrit] New patch to review for coreboot: bb59036 Fix bug in the Geode LX CAR init: constant value not memory reference.

[Christopher Kilgour (techie@whiterocker.com)]

Christopher Kilgour (techie at whiterocker.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3478

-gerrit

commit bb5903629bd926cc50728e3742f50ab76b510d83
Author: Christopher Kilgour <techie at whiterocker.com>
Date:   Sat Jun 15 23:52:36 2013 -0700

    Fix bug in the Geode LX CAR init: constant value not memory reference.
    
    An uninitialized RAM value was used to select an MSR, but it should be the
    constant value 0x1800, corresponding to DM_CONFIG0_MSR.
    
    Change-Id: Id53ca98b06cc4a9b55916fd8db23904f98008d45
    Signed-off-by: Christopher Kilgour <techie at whiterocker.com>
---
 src/cpu/amd/geode_lx/cache_as_ram.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cpu/amd/geode_lx/cache_as_ram.inc b/src/cpu/amd/geode_lx/cache_as_ram.inc
index d2c2415..45fd166 100644
--- a/src/cpu/amd/geode_lx/cache_as_ram.inc
+++ b/src/cpu/amd/geode_lx/cache_as_ram.inc
@@ -46,7 +46,7 @@ DCacheSetup:
 	wrmsr
 
 	/* in LX DCDIS is set after POR which disables the cache..., clear this bit */
-	movl	CPU_DM_CONFIG0,%ecx
+	movl	$CPU_DM_CONFIG0,%ecx
 	rdmsr
 	andl	$(~(DM_CONFIG0_LOWER_DCDIS_SET)), %eax	/* TODO: make consistent with i$ init,	either whole reg = 0,  or just this bit... */
 	wrmsr