[coreboot-gerrit] Patch set updated for coreboot: eba39d2 cpu/amd/geode_lx/cache_as_ram.inc: Use $ for constant value instead of memory reference
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Sun Jun 16 10:20:36 CEST 2013
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3478
-gerrit
commit eba39d25210f4e26382cf8107939731765218eba
Author: Christopher Kilgour <techie at whiterocker.com>
Date: Sat Jun 15 23:52:36 2013 -0700
cpu/amd/geode_lx/cache_as_ram.inc: Use $ for constant value instead of memory reference
An uninitialized RAM value was used to select an MSR because a $ was forgotten
in front of `CPU_DM_CONFIG0`. It should be the constant value 0x1800, corresponding
to CPU_DM_CONFIG0 MSR defined in `src/include/cpu/amd/lxdef.h`.
Change-Id: Id53ca98b06cc4a9b55916fd8db23904f98008d45
Signed-off-by: Christopher Kilgour <techie at whiterocker.com>
---
src/cpu/amd/geode_lx/cache_as_ram.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/cpu/amd/geode_lx/cache_as_ram.inc b/src/cpu/amd/geode_lx/cache_as_ram.inc
index d2c2415..45fd166 100644
--- a/src/cpu/amd/geode_lx/cache_as_ram.inc
+++ b/src/cpu/amd/geode_lx/cache_as_ram.inc
@@ -46,7 +46,7 @@ DCacheSetup:
wrmsr
/* in LX DCDIS is set after POR which disables the cache..., clear this bit */
- movl CPU_DM_CONFIG0,%ecx
+ movl $CPU_DM_CONFIG0,%ecx
rdmsr
andl $(~(DM_CONFIG0_LOWER_DCDIS_SET)), %eax /* TODO: make consistent with i$ init, either whole reg = 0, or just this bit... */
wrmsr
More information about the coreboot-gerrit
mailing list