[coreboot-gerrit] Patch set updated for coreboot: 92bed3b SB700: Set Azalia configuration flags
Bruce Griffith (Bruce.Griffith@se-eng.com)
gerrit at coreboot.org
Wed Jun 26 12:05:58 CEST 2013
Bruce Griffith (Bruce.Griffith at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3544
-gerrit
commit 92bed3bddd0a8dd3928e73ee162071cdff4dbdbd
Author: Bruce Griffith <Bruce.Griffith at se-eng.com>
Date: Tue Jun 25 14:01:21 2013 -0600
SB700: Set Azalia configuration flags
The existing code for setting Azalia configuration assumes that
the configuration bits are contiguous within a single byte and
can be set using a byte copy addressed into the lowest 2-bit
subfield.
The fix in Family 14 defines a union that can be addressed as a
byte to overlay the bit fields. Since the offset of the four
subfields is not necessarily fixed, change the code to initialize
each of the four subfields individually.
Change-Id: I1dff20bb8bd3e1bcd8b4e6b0537e20779d2a3521
Signed-off-by: Bruce Griffith <Bruce.Griffith at se-eng.com>
---
src/mainboard/amd/dinar/sb700_cfg.c | 5 ++++-
src/mainboard/amd/dinar/sb700_cfg.h | 6 +++++-
src/mainboard/supermicro/h8qgi/sb700_cfg.c | 5 ++++-
src/mainboard/supermicro/h8qgi/sb700_cfg.h | 6 +++++-
src/mainboard/supermicro/h8scm/sb700_cfg.c | 5 ++++-
src/mainboard/supermicro/h8scm/sb700_cfg.h | 6 +++++-
6 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/src/mainboard/amd/dinar/sb700_cfg.c b/src/mainboard/amd/dinar/sb700_cfg.c
index 94e4b40..c9a0949 100644
--- a/src/mainboard/amd/dinar/sb700_cfg.c
+++ b/src/mainboard/amd/dinar/sb700_cfg.c
@@ -126,7 +126,10 @@ void sb700_cimx_config(AMDSBCFG *sb_config)
/* Azalia HDA */
sb_config->AzaliaController = AZALIA_CONTROLLER;
sb_config->AzaliaPinCfg = AZALIA_PIN_CONFIG;
- sb_config->AzaliaSdin0 = AZALIA_SDIN_PIN;
+ sb_config->AzaliaSdin0 = AZALIA_SDIN_PIN_0;
+ sb_config->AzaliaSdin1 = AZALIA_SDIN_PIN_1;
+ sb_config->AzaliaSdin2 = AZALIA_SDIN_PIN_2;
+ sb_config->AzaliaSdin3 = AZALIA_SDIN_PIN_3;
sb_config->pAzaliaOemCodecTablePtr = NULL;
#ifndef __PRE_RAM__
diff --git a/src/mainboard/amd/dinar/sb700_cfg.h b/src/mainboard/amd/dinar/sb700_cfg.h
index 371c7ce..216c264 100644
--- a/src/mainboard/amd/dinar/sb700_cfg.h
+++ b/src/mainboard/amd/dinar/sb700_cfg.h
@@ -192,7 +192,11 @@
*/
#ifndef AZALIA_SDIN_PIN
//#define AZALIA_SDIN_PIN 0xAA
-#define AZALIA_SDIN_PIN 0x2A
+#define AZALIA_SDIN_PIN
+#define AZALIA_SDIN_PIN_0 0x2
+#define AZALIA_SDIN_PIN_1 0x2
+#define AZALIA_SDIN_PIN_2 0x2
+#define AZALIA_SDIN_PIN_3 0x0
#endif
/**
diff --git a/src/mainboard/supermicro/h8qgi/sb700_cfg.c b/src/mainboard/supermicro/h8qgi/sb700_cfg.c
index 54c139a..ff2334f 100644
--- a/src/mainboard/supermicro/h8qgi/sb700_cfg.c
+++ b/src/mainboard/supermicro/h8qgi/sb700_cfg.c
@@ -126,7 +126,10 @@ void sb700_cimx_config(AMDSBCFG *sb_config)
/* Azalia HDA */
sb_config->AzaliaController = AZALIA_CONTROLLER;
sb_config->AzaliaPinCfg = AZALIA_PIN_CONFIG;
- sb_config->AzaliaSdin0 = AZALIA_SDIN_PIN;
+ sb_config->AzaliaSdin0 = AZALIA_SDIN_PIN_0;
+ sb_config->AzaliaSdin1 = AZALIA_SDIN_PIN_1;
+ sb_config->AzaliaSdin2 = AZALIA_SDIN_PIN_2;
+ sb_config->AzaliaSdin3 = AZALIA_SDIN_PIN_3;
sb_config->pAzaliaOemCodecTablePtr = NULL;
#ifndef __PRE_RAM__
diff --git a/src/mainboard/supermicro/h8qgi/sb700_cfg.h b/src/mainboard/supermicro/h8qgi/sb700_cfg.h
index a3e5a38..1df3fc5 100644
--- a/src/mainboard/supermicro/h8qgi/sb700_cfg.h
+++ b/src/mainboard/supermicro/h8qgi/sb700_cfg.h
@@ -192,7 +192,11 @@
*/
#ifndef AZALIA_SDIN_PIN
//#define AZALIA_SDIN_PIN 0xAA
-#define AZALIA_SDIN_PIN 0x2A
+#define AZALIA_SDIN_PIN
+#define AZALIA_SDIN_PIN_0 0x2
+#define AZALIA_SDIN_PIN_1 0x2
+#define AZALIA_SDIN_PIN_2 0x2
+#define AZALIA_SDIN_PIN_3 0x0
#endif
/**
diff --git a/src/mainboard/supermicro/h8scm/sb700_cfg.c b/src/mainboard/supermicro/h8scm/sb700_cfg.c
index 12169e6..c03a501 100644
--- a/src/mainboard/supermicro/h8scm/sb700_cfg.c
+++ b/src/mainboard/supermicro/h8scm/sb700_cfg.c
@@ -126,7 +126,10 @@ void sb700_cimx_config(AMDSBCFG *sb_config)
/* Azalia HDA */
sb_config->AzaliaController = AZALIA_CONTROLLER;
sb_config->AzaliaPinCfg = AZALIA_PIN_CONFIG;
- sb_config->AzaliaSdin0 = AZALIA_SDIN_PIN;
+ sb_config->AzaliaSdin0 = AZALIA_SDIN_PIN_0;
+ sb_config->AzaliaSdin1 = AZALIA_SDIN_PIN_1;
+ sb_config->AzaliaSdin2 = AZALIA_SDIN_PIN_2;
+ sb_config->AzaliaSdin3 = AZALIA_SDIN_PIN_3;
sb_config->pAzaliaOemCodecTablePtr = NULL;
#ifndef __PRE_RAM__
diff --git a/src/mainboard/supermicro/h8scm/sb700_cfg.h b/src/mainboard/supermicro/h8scm/sb700_cfg.h
index eca355f..40c89fa 100644
--- a/src/mainboard/supermicro/h8scm/sb700_cfg.h
+++ b/src/mainboard/supermicro/h8scm/sb700_cfg.h
@@ -192,7 +192,11 @@
*/
#ifndef AZALIA_SDIN_PIN
//#define AZALIA_SDIN_PIN 0xAA
-#define AZALIA_SDIN_PIN 0x2A
+#define AZALIA_SDIN_PIN
+#define AZALIA_SDIN_PIN_0 0x2
+#define AZALIA_SDIN_PIN_1 0x2
+#define AZALIA_SDIN_PIN_2 0x2
+#define AZALIA_SDIN_PIN_3 0x0
#endif
/**
More information about the coreboot-gerrit
mailing list