[coreboot-gerrit] New patch to review for coreboot: 742d427 cbmem: Fix makefile

Stefan Tauner (stefan.tauner@gmx.at) gerrit at coreboot.org
Wed Jun 26 18:30:19 CEST 2013


Stefan Tauner (stefan.tauner at gmx.at) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3548

-gerrit

commit 742d427a1ae4472544fc5db335f9a4f86f5e592f
Author: Stefan Tauner <stefan.tauner at gmx.at>
Date:   Wed Jun 26 18:22:53 2013 +0200

    cbmem: Fix makefile
    
    The .dependencies rule did not use the CPPFLAGS variable which led
    to funny behavior: a spurious termination message the first time
    (after checkout/make distclean) one executes make. Afterwards the
    (wrongly) empty .dependencies file hides the problem and the binary
    is created anyway.
    
    $ make
    cbmem.c:37:34: fatal error: boot/coreboot_tables.h: No such file or directory
    compilation terminated.
    cc -O2 -Wall -Werror -iquote ../../src/include -iquote ../../src/src/arch/x86  -c -o cbmem.o cbmem.c
    cc   cbmem.o   -o cbmem
    
    $ make
    make: Nothing to be done for `all'.
    
    $ make clean
    rm -f cbmem *.o *~
    
    $ make
    cc -O2 -Wall -Werror -iquote ../../src/include -iquote ../../src/src/arch/x86  -c -o cbmem.o cbmem.c
    cc   cbmem.o   -o cbmem
    
    $ make distclean
    rm -f cbmem *.o *~
    rm -f .dependencies
    
    $ make
    cbmem.c:37:34: fatal error: boot/coreboot_tables.h: No such file or directory
    compilation terminated.
    cc -O2 -Wall -Werror -iquote ../../src/include -iquote ../../src/src/arch/x86  -c -o cbmem.o cbmem.c
    cc   cbmem.o   -o cbmem
    
    I fixed that by just (re)using the CFLAGS variable.
    
    Change-Id: Icd11b146ad762cbdf9774630b950f70e1253a072
    Signed-off-by: Stefan Tauner <stefan.tauner at gmx.at>
---
 util/cbmem/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile
index c93863a..31c911b 100644
--- a/util/cbmem/Makefile
+++ b/util/cbmem/Makefile
@@ -22,7 +22,7 @@ ROOT = ../../src
 CC     ?= $(CROSS_COMPILE)gcc
 CFLAGS ?= -O2
 CFLAGS += -Wall -Werror
-CPPFLAGS += -iquote $(ROOT)/include -iquote $(ROOT)/src/arch/x86
+CFLAGS += -iquote $(ROOT)/include -iquote $(ROOT)/src/arch/x86
 
 OBJS = $(PROGRAM).o
 



More information about the coreboot-gerrit mailing list