[coreboot-gerrit] Patch set updated for coreboot: 166dfbb cbmem: Makefile: Add compilation rule

Nico Huber (nico.huber@secunet.com) gerrit at coreboot.org
Fri Jun 28 11:32:20 CEST 2013


Nico Huber (nico.huber at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3028

-gerrit

commit 166dfbb84b1cbfdf9b8611872f677a7ce02772b8
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Apr 5 11:12:12 2013 +0200

    cbmem: Makefile: Add compilation rule
    
    Commit »cbmem compilation needs to use the hardened toolchain«
    (7c6b6bb5) [1] introduced `CPPFLAGS` but used `CFLAGS`, which might
    give the following build error, which was not spotted by Jenkins.
    
        cbmem.c:36:34: fatal error: boot/coreboot_tables.h: Datei oder Verzeichnis nicht gefunden
        compilation terminated.
    
    Looks like the default compilation rule does not always include
    `CPPFLAGS`. Therefore, add a more complete compilation rule.
    
    [1] http://review.coreboot.org/1791
    
    Change-Id: I254d76c7d98b6f920501407239566e9655b2ddeb
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 util/cbmem/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile
index c93863a..d41d324 100644
--- a/util/cbmem/Makefile
+++ b/util/cbmem/Makefile
@@ -28,6 +28,9 @@ OBJS = $(PROGRAM).o
 
 all: $(PROGRAM)
 
+%.o: %.c
+	$(CC) $(CPPFLAGS) $(CFLAGS) -c $<
+
 $(PROGRAM): $(OBJS)
 
 clean:



More information about the coreboot-gerrit mailing list