[coreboot-gerrit] New patch to review for coreboot: 88a3ece cpu/amd/agesa/s3_resume.c: Remove unused variable

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sun Jun 30 15:13:12 CEST 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3575

-gerrit

commit 88a3ece87a407a718c55ec5b302596336cab6365
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat Jun 29 19:55:34 2013 +0200

    cpu/amd/agesa/s3_resume.c: Remove unused variable
    
    Change-Id: Ic0a41499e53a48ceec5c52dec155b7d6759bf2f0
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/cpu/amd/agesa/s3_resume.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/cpu/amd/agesa/s3_resume.c b/src/cpu/amd/agesa/s3_resume.c
index 6ba9212..16d5383 100644
--- a/src/cpu/amd/agesa/s3_resume.c
+++ b/src/cpu/amd/agesa/s3_resume.c
@@ -240,7 +240,6 @@ u32 OemAgesaSaveS3Info(S3_DATA_TYPE S3DataType, u32 DataSize, void *Data)
 {
 
 	u32 pos = S3_DATA_VOLATILE_POS;
-	u32 data;
 	u32 nvram_pos;
 	struct spi_flash *flash;
 
@@ -270,11 +269,10 @@ u32 OemAgesaSaveS3Info(S3_DATA_TYPE S3DataType, u32 DataSize, void *Data)
 	nvram_pos = 0;
 	flash->write(flash, nvram_pos + pos, sizeof(DataSize), &DataSize);
 
-	for (nvram_pos = 0; nvram_pos < DataSize - CONFIG_AMD_SB_SPI_TX_LEN; nvram_pos += CONFIG_AMD_SB_SPI_TX_LEN) {
-		data = *(u32 *) (Data + nvram_pos);
-		flash->write(flash, nvram_pos + pos + 4, CONFIG_AMD_SB_SPI_TX_LEN, (u8 *)(Data + nvram_pos));
-	}
-	flash->write(flash, nvram_pos + pos + 4, DataSize % CONFIG_AMD_SB_SPI_TX_LEN, (u8 *)(Data + nvram_pos));
+	for (nvram_pos = 0; nvram_pos < DataSize - CONFIG_AMD_SB_SPI_TX_LEN; nvram_pos += CONFIG_AMD_SB_SPI_TX_LEN)
+		flash->write(flash, nvram_pos + pos + sizeof(DataSize), CONFIG_AMD_SB_SPI_TX_LEN, (u8 *)(Data + nvram_pos));
+
+	flash->write(flash, nvram_pos + pos + sizeof(DataSize), DataSize % CONFIG_AMD_SB_SPI_TX_LEN, (u8 *)(Data + nvram_pos));
 
 	flash->spi->rw = SPI_WRITE_FLAG;
 	spi_release_bus(flash->spi);



More information about the coreboot-gerrit mailing list