[coreboot-gerrit] Patch merged into coreboot/master: ef4275b x86: protect against abi assumptions from compiler

gerrit at coreboot.org gerrit at coreboot.org
Thu Mar 21 22:47:43 CET 2013


the following patch was just integrated into master:
commit ef4275bc2e4332ed9b6f3ac25060687794f0b98d
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Feb 8 22:31:33 2013 -0600

    x86: protect against abi assumptions from compiler
    
    Some of the functions called from assembly assume the standard
    x86 32-bit ABI of passing all arguments on the stack. However,
    that calling ABI can be changed by compiler flags. In order to
    protect against the current implicit calling convention annotate
    the functions called from assembly with the cdecl function
    attribute. That tells the compiler to use the stack based parameter
    calling convention.
    
    Change-Id: I83625e1f92c6821a664b191b6ce1250977cf037a
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/2794
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Tue Mar 19 05:16:31 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Thu Mar 21 22:47:41 2013, giving +2
See http://review.coreboot.org/2794 for details.

-gerrit



More information about the coreboot-gerrit mailing list