[coreboot-gerrit] Patch set updated for coreboot: 9a5c1ef Lenovo X60: dsdt.asl: Add _OSC method

Denis Carikli (GNUtoo@no-log.org) gerrit at coreboot.org
Fri Mar 29 08:34:17 CET 2013


Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2938

-gerrit

commit 9a5c1ef264567a4bdd7a1ddaeac592cc5a1e19bd
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date:   Thu Mar 28 14:24:39 2013 +0100

    Lenovo X60: dsdt.asl: Add _OSC method
    
    This commit was modelled after the following commit:
      00a0e76bc5ffaba01c98f1c1384b0499516fdaef
      (AMD Fam14 DSDT: Add OSC method)
    
    Tested under the parabola GNU/Linux distribution:
    Before that change:
    $ dmesg | egrep -e OSC -e ASPM
    [    0.108036] pci_root PNP0A08:00: ACPI _OSC support notification failed, disabling PCIe ASPM
    [    0.108040] pci_root PNP0A08:00: Unable to request _OSC control (_OSC support mask: 0x08)
    [    0.118089] ACPI _OSC control for PCIe not granted, disabling ASPM
    [   16.874569] e1000e 0000:01:00.0: Disabling ASPM L0s L1
    With that change:
    $ dmesg | egrep -e OSC -e ASPM
    [    0.107962] pci_root PNP0A08:00: Requesting ACPI _OSC control (0x1d)
    [    0.108003] pci_root PNP0A08:00: ACPI _OSC control (0x1d) granted
    [    0.111052] pci 0000:01:00.0: disabling ASPM on pre-1.1 PCIe device.  You can enable it with 'pcie_aspm=force'
    [   17.537970] e1000e 0000:01:00.0: Disabling ASPM L0s L1
    
    Change-Id: I1caffa44eea447d553c01caaf431f2db241ea5ea
    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
 src/mainboard/lenovo/x60/dsdt.asl | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/mainboard/lenovo/x60/dsdt.asl b/src/mainboard/lenovo/x60/dsdt.asl
index f32a220..d3a36c0 100644
--- a/src/mainboard/lenovo/x60/dsdt.asl
+++ b/src/mainboard/lenovo/x60/dsdt.asl
@@ -45,6 +45,16 @@ DefinitionBlock(
 		{
 			#include <northbridge/intel/i945/acpi/i945.asl>
 			#include <southbridge/intel/i82801gx/acpi/ich7.asl>
+
+			/* Operating System Capabilities Method */
+			Method(_OSC, 4)
+			{	/* Check for proper PCI/PCIe UUID */
+				If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))
+				{
+					/* Let OS control everything */
+					Return (Arg3)
+				}
+			}
 		}
 	}
 



More information about the coreboot-gerrit mailing list