[coreboot-gerrit] New patch to review for coreboot: 440d4f1 AMD Fam15tn boards: BiosCallOuts.c: Remove board name from `CodecTableList`

[Paul Menzel (paulepanter@users.sourceforge.net)]

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3199

-gerrit

commit 440d4f18835be93c0615ba4918123ccd798335df
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat May 4 18:41:54 2013 +0200

    AMD Fam15tn boards: BiosCallOuts.c: Remove board name from `CodecTableList`
    
    The board name in that variable name is not necessary, as it is not board
    dependent, that means using the file as a template for making a new
    coreboot port for another motherboard the variable does not need to be
    changed, and just increases the code differences between AMD Parmer,
    AMD Thather and ASUS F2A85-M. So use a generic name.
    
    The same was done for AMD Persimmon (and inherited by the LiPPERT
    FrontRunner/Toucan-AF) in the following commit.
    
        commit 5e70766f14253f53190ddd49a544460c6bc1e528
        Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
        Date:   Tue Feb 26 15:56:11 2013 +0100
    
            AMD Fam14 boards: reduce unnecessary differences, 2nd attempt
    
            Reviewed-on: http://review.coreboot.org/2529
    
    The board name is *not* removed from the `CODEC_ENTRY` variable name as
    the verb table not only depends on the codec but also on the board [1].
    Having the board name in the variable name is a good indicator that the
    contents also needs to be adapted when taking this file as a template for
    a new port.
    
    [1] Unfortunately I was not able to find Jens’ comment in my mail archive
        and in the Gerrit Web interface. Not sure where it is, but I am sure
        he made that comment.
    
    Change-Id: I440a306cf4ff0a5b1b61d1983d70c66d129904d0
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/amd/parmer/BiosCallOuts.c   | 4 ++--
 src/mainboard/amd/thatcher/BiosCallOuts.c | 4 ++--
 src/mainboard/asus/f2a85-m/BiosCallOuts.c | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/amd/parmer/BiosCallOuts.c b/src/mainboard/amd/parmer/BiosCallOuts.c
index 9592c9d..58bcd02 100644
--- a/src/mainboard/amd/parmer/BiosCallOuts.c
+++ b/src/mainboard/amd/parmer/BiosCallOuts.c
@@ -83,7 +83,7 @@ static const CODEC_ENTRY Parmer_Alc272_VerbTbl[] = {
 	{0xff, 0xffffffff}
 };
 
-static const CODEC_TBL_LIST ParmerCodecTableList[] =
+static const CODEC_TBL_LIST CodecTableList[] =
 {
 	{0x10ec0272, (CODEC_ENTRY*)&Parmer_Alc272_VerbTbl[0]},
 	{(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL}
@@ -287,7 +287,7 @@ AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr)
 		printk(BIOS_DEBUG, "Fch OEM config in INIT ENV ");
 
 		/* Azalia Controller OEM Codec Table Pointer */
-		FchParams_env->Azalia.AzaliaOemCodecTablePtr = (CODEC_TBL_LIST *)(&ParmerCodecTableList[0]);
+		FchParams_env->Azalia.AzaliaOemCodecTablePtr = (CODEC_TBL_LIST *)(&CodecTableList[0]);
 		/* Azalia Controller Front Panel OEM Table Pointer */
 
 		/* Fan Control */
diff --git a/src/mainboard/amd/thatcher/BiosCallOuts.c b/src/mainboard/amd/thatcher/BiosCallOuts.c
index 6979522..60a33ed 100644
--- a/src/mainboard/amd/thatcher/BiosCallOuts.c
+++ b/src/mainboard/amd/thatcher/BiosCallOuts.c
@@ -83,7 +83,7 @@ static const CODEC_ENTRY Thatcher_Alc272_VerbTbl[] = {
 	{0xff, 0xffffffff}
 };
 
-static const CODEC_TBL_LIST ThatcherCodecTableList[] =
+static const CODEC_TBL_LIST CodecTableList[] =
 {
 	{0x10ec0272, (CODEC_ENTRY*)&Thatcher_Alc272_VerbTbl[0]},
 	{(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL}
@@ -287,7 +287,7 @@ AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr)
 		printk(BIOS_DEBUG, "Fch OEM config in INIT ENV ");
 
 		/* Azalia Controller OEM Codec Table Pointer */
-		FchParams_env->Azalia.AzaliaOemCodecTablePtr = (CODEC_TBL_LIST *)(&ThatcherCodecTableList[0]);
+		FchParams_env->Azalia.AzaliaOemCodecTablePtr = (CODEC_TBL_LIST *)(&CodecTableList[0]);
 		/* Azalia Controller Front Panel OEM Table Pointer */
 
 		/* Fan Control */
diff --git a/src/mainboard/asus/f2a85-m/BiosCallOuts.c b/src/mainboard/asus/f2a85-m/BiosCallOuts.c
index e913896..0a13208 100644
--- a/src/mainboard/asus/f2a85-m/BiosCallOuts.c
+++ b/src/mainboard/asus/f2a85-m/BiosCallOuts.c
@@ -83,7 +83,7 @@ static const CODEC_ENTRY Thatcher_Alc272_VerbTbl[] = {
 	{0xff, 0xffffffff}
 };
 
-static const CODEC_TBL_LIST ThatcherCodecTableList[] =
+static const CODEC_TBL_LIST CodecTableList[] =
 {
 	{0x10ec0272, (CODEC_ENTRY*)&Thatcher_Alc272_VerbTbl[0]},
 	{(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL}
@@ -110,7 +110,7 @@ AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr)
 		printk(BIOS_DEBUG, "Fch OEM config in INIT ENV ");
 
 		/* Azalia Controller OEM Codec Table Pointer */
-		FchParams_env->Azalia.AzaliaOemCodecTablePtr = (CODEC_TBL_LIST *)(&ThatcherCodecTableList[0]);
+		FchParams_env->Azalia.AzaliaOemCodecTablePtr = (CODEC_TBL_LIST *)(&CodecTableList[0]);
 		/* Azalia Controller Front Panel OEM Table Pointer */
 		FchParams_env->Imc.ImcEnable = FALSE;
 		FchParams_env->Hwm.HwMonitorEnable = FALSE;