[coreboot-gerrit] New patch to review for coreboot: 7a6c4b1 AMD AGESA Hudson: Include `stdint.h` and `io.h` to fix build

[Paul Menzel (paulepanter@users.sourceforge.net)]

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3202

-gerrit

commit 7a6c4b12ae11f36f7b6da7fbd32565ef2e4167c0
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon May 6 15:18:57 2013 +0200

    AMD AGESA Hudson: Include `stdint.h` and `io.h` to fix build
    
    Apparently the files `smbus.{h,c}`, where never used and therefore
    build beforehand. Needing one function in them for the ASUS F2A85-M
    the build fails as some headers are missing. Including the headers
    `stdint.h` and `io.h` fixes the following errors.
    
        […]
            CC         southbridge/amd/agesa/hudson/smbus.romstage.o
        In file included from src/southbridge/amd/agesa/hudson/smbus.c:23:0:
        src/southbridge/amd/agesa/hudson/smbus.h:67:24: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:67:43: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:67:55: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:68:25: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:68:44: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:68:56: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:68:69: error: unknown type name 'u8'
        src/southbridge/amd/agesa/hudson/smbus.h:69:24: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:69:43: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:70:24: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:70:43: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:70:55: error: unknown type name 'u8'
        src/southbridge/amd/agesa/hudson/smbus.h:71:20: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:71:35: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:71:49: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:71:59: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:71:69: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:72:20: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:72:35: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:72:49: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:72:59: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:73:20: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:73:32: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:73:44: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:73:54: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.c: In function 'smbus_delay':
        src/southbridge/amd/agesa/hudson/smbus.c:27:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
        src/southbridge/amd/agesa/hudson/smbus.c:27:2: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]
        […]
    
    Probably all the (AMD(?)) `smbus.{h,c}` suffer from this and
    should be fixed. Even better, as these function do not differ
    between most boards, the file should be moved out from the
    specific southbridge directories.
    
    [1] http://qa.coreboot.org/job/coreboot-gerrit/6168/testReport/junit/(root)/board/i386_asus_f2a85_m/
    
    Change-Id: I285101fa06a365da44fa27b688c536e614d57f50
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/southbridge/amd/agesa/hudson/smbus.c | 2 ++
 src/southbridge/amd/agesa/hudson/smbus.h | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/southbridge/amd/agesa/hudson/smbus.c b/src/southbridge/amd/agesa/hudson/smbus.c
index 682b86d..e428d43 100644
--- a/src/southbridge/amd/agesa/hudson/smbus.c
+++ b/src/southbridge/amd/agesa/hudson/smbus.c
@@ -20,6 +20,8 @@
 #ifndef  _HUDSON_SMBUS_C_
 #define  _HUDSON_SMBUS_C_
 
+#include <io.h>
+#include <stdint.h>
 #include "smbus.h"
 
 static inline void smbus_delay(void)
diff --git a/src/southbridge/amd/agesa/hudson/smbus.h b/src/southbridge/amd/agesa/hudson/smbus.h
index b194aae..53cc0e6 100644
--- a/src/southbridge/amd/agesa/hudson/smbus.h
+++ b/src/southbridge/amd/agesa/hudson/smbus.h
@@ -20,7 +20,7 @@
 #ifndef HUDSON_SMBUS_H
 #define HUDSON_SMBUS_H
 
-//#include <stdint.h>
+#include <stdint.h>
 
 #define SMBHSTSTAT 0x0
 #define SMBSLVSTAT 0x1