[coreboot-gerrit] Patch merged into coreboot/master: ddddf15 Intel 82801Gx: LPC: Unify I/O APIC setup
gerrit at coreboot.org
gerrit at coreboot.org
Tue May 7 22:41:00 CEST 2013
the following patch was just integrated into master:
commit ddddf15ca359e932ed2e61e9a6dcec77ed2d4411
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Tue Apr 23 14:40:23 2013 +0200
Intel 82801Gx: LPC: Unify I/O APIC setup
Remove local copies of reading and writing I/O APIC registers by
using already available functions.
This change is similar to
commit db4f875a412e6c41f48a86a79b72465f6cd81635
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date: Tue Jan 31 17:24:12 2012 +0200
IOAPIC: Divide setup_ioapic() in two parts.
Reviewed-on: http://review.coreboot.org/300
and
commit e614353194c712a40aa8444a530b2062876eabe3
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date: Tue Feb 26 17:24:41 2013 +0200
Unify setting 82801a/b/c/d IOAPIC ID
Reviewed-on: http://review.coreboot.org/2532
and uses `io_apic_read()` and `io_apic_write()` too.
As commented by Aaron Durbin, a separate `i82801gx_enable_acpi()` is
not needed: “The existing code path *in this file* is about enabling
the io apic.” [1].
[1] http://review.coreboot.org/#/c/3182/4/src/southbridge/intel/lynxpoint/lpc.c
Change-Id: I104a2d9c2898da14d26f8f2992d5a065ad640356
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/3181
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin at google.com>
Build-Tested: build bot (Jenkins) at Tue May 7 19:56:29 2013, giving +1
Reviewed-By: Aaron Durbin <adurbin at google.com> at Tue May 7 20:02:31 2013, giving +2
See http://review.coreboot.org/3181 for details.
-gerrit
More information about the coreboot-gerrit
mailing list