[coreboot-gerrit] Patch merged into coreboot/master: d654f42 AMD: Reduce stack size from 64 KB to the default of 4 KB

[gerrit at coreboot.org]

the following patch was just integrated into master:
commit d654f42e271b2daa17a4daddcb7c9603aa25e018
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Wed May 8 13:23:14 2013 +0200

    AMD: Reduce stack size from 64 KB to the default of 4 KB
    
    Apply the following commit to all AMD boards.
    
        commit 935850e08293cec1cb27d12358b27285e780566a
        Author: Stefan Reinauer <reinauer at chromium.org>
        Date:   Mon May 6 16:16:03 2013 -0700
    
            asrock/e350m1: reduce default stack size
    
            The stack used on the ASRock E350M1 is significantly less than
            what we currently set (64k per core). In fact, we use about half
            of the default stack size (4k) on core 0 and even less on non
            BSP cores [1]:
    
            $ grep stack coreboot_without_patch_but_monotonic_timer.log
            CPU1: stack_base 002a0000, stack_end 002afff8
            CPU1: stack: 002a0000 - 002b0000, lowest used address 002afda8, stack used: 600 bytes
            CPU0: stack: 002b0000 - 002c0000, lowest used address 002bf75c, stack used: 2212 bytes
    
            […]
    
            Reviewed-on: http://review.coreboot.org/3209
    
    Please note that AGESA seems to define bigger stack sizes. But
    these seem to be too much too.
    
        $ git grep STACK_SIZE src/vendorcode/amd
        […]
        src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:#define BSP_STACK_SIZE            16384
        src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:#define CORE0_STACK_SIZE          16384
        src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:#define CORE1_STACK_SIZE          4096
        src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:  BSP_STACK_SIZE,
        src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:  CORE0_STACK_SIZE,
        src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:  CORE1_STACK_SIZE,
        […]
    
    The following command was used to create the patch.
    
        $ git grep -l STACK_SIZE src/mainboard/ | xargs sed -i '/STACK_SIZE/,+3d'
    
    Change-Id: I36b95b7a6f190b64d0639fc036ce2fb0253f3fa1
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3217
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/3217 for details.

-gerrit