[coreboot-gerrit] Patch merged into coreboot/master: 883b03f AMD AGESA Hudson: Include `stdint.h` and `io.h` to fix build

gerrit at coreboot.org gerrit at coreboot.org
Mon May 20 18:34:19 CEST 2013


the following patch was just integrated into master:
commit 883b03f3230ad032dffae9e3e053c6c1963abebc
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon May 6 15:18:57 2013 +0200

    AMD AGESA Hudson: Include `stdint.h` and `io.h` to fix build
    
    Apparently the files `smbus.{h,c}`, where never used and therefore
    build beforehand. Needing one function in them for the ASUS F2A85-M
    the build fails as some headers are missing. Including the headers
    `stdint.h` and `io.h` fixes the following errors.
    
        […]
            CC         southbridge/amd/agesa/hudson/smbus.romstage.o
        In file included from src/southbridge/amd/agesa/hudson/smbus.c:23:0:
        src/southbridge/amd/agesa/hudson/smbus.h:67:24: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:67:43: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:67:55: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:68:25: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:68:44: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:68:56: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:68:69: error: unknown type name 'u8'
        src/southbridge/amd/agesa/hudson/smbus.h:69:24: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:69:43: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:70:24: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:70:43: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:70:55: error: unknown type name 'u8'
        src/southbridge/amd/agesa/hudson/smbus.h:71:20: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:71:35: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:71:49: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:71:59: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:71:69: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:72:20: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:72:35: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:72:49: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:72:59: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:73:20: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:73:32: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:73:44: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.h:73:54: error: unknown type name 'u32'
        src/southbridge/amd/agesa/hudson/smbus.c: In function 'smbus_delay':
        src/southbridge/amd/agesa/hudson/smbus.c:27:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
        src/southbridge/amd/agesa/hudson/smbus.c:27:2: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]
        […]
    
    Probably all the (AMD(?)) `smbus.{h,c}` suffer from this and
    should be fixed. Even better, as these function do not differ
    between most boards, the file should be moved out from the
    specific southbridge directories.
    
    [1] http://qa.coreboot.org/job/coreboot-gerrit/6168/testReport/junit/(root)/board/i386_asus_f2a85_m/
    
    Change-Id: I285101fa06a365da44fa27b688c536e614d57f50
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3202
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martin.roth at se-eng.com>
    Reviewed-by: Dave Frodin <dave.frodin at se-eng.com>


See http://review.coreboot.org/3202 for details.

-gerrit



More information about the coreboot-gerrit mailing list