[coreboot-gerrit] New patch to review for coreboot: 9dace0d (TRIVIAL) Various boards: Move spd.h include higher up

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Wed May 22 02:10:10 CEST 2013


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3269

-gerrit

commit 9dace0db8ad74b82ed2dbc237d198444cc96e658
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Tue May 21 18:44:50 2013 -0500

    (TRIVIAL) Various boards: Move spd.h include higher up
    
    When placing a define, the following boards would fail to compile:
    board.i386/amd/serengeti_cheetah
    board.i386/hp/dl145_g3
    board.i386/msi/ms9185
    
    The error looked like:
    > spd.h: error: expected identifier before '(' token
    
    This is an example of a build that fails:
    http://qa.coreboot.org/job/coreboot-gerrit/6351/#showFailuresLink
    
    Move the <spd.h> include higher up. This is a quick and safe fix to the
    problem.
    
    Change-Id: Ib8cb78468c2922322b490e0b52c0bd24f3de7ef9
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/mainboard/amd/serengeti_cheetah/romstage.c | 2 +-
 src/mainboard/hp/dl145_g3/romstage.c           | 2 +-
 src/mainboard/msi/ms9185/romstage.c            | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/amd/serengeti_cheetah/romstage.c b/src/mainboard/amd/serengeti_cheetah/romstage.c
index 8d985b7..f13a7c4 100644
--- a/src/mainboard/amd/serengeti_cheetah/romstage.c
+++ b/src/mainboard/amd/serengeti_cheetah/romstage.c
@@ -10,6 +10,7 @@
 #include <device/pnp_def.h>
 #include <pc80/mc146818rtc.h>
 #include <console/console.h>
+#include <spd.h>
 #include <cpu/amd/model_fxx_rev.h>
 #include "southbridge/amd/amd8111/early_smbus.c"
 #include <reset.h>
@@ -77,7 +78,6 @@ static inline int spd_read_byte(unsigned device, unsigned address)
 #include "lib/generic_sdram.c"
 #include "resourcemap.c"
 #include "cpu/amd/dualcore/dualcore.c"
-#include <spd.h>
 #include "cpu/amd/car/post_cache_as_ram.c"
 #include "cpu/amd/model_fxx/init_cpus.c"
 #include "cpu/amd/model_fxx/fidvid.c"
diff --git a/src/mainboard/hp/dl145_g3/romstage.c b/src/mainboard/hp/dl145_g3/romstage.c
index ff20289..c8d035d 100644
--- a/src/mainboard/hp/dl145_g3/romstage.c
+++ b/src/mainboard/hp/dl145_g3/romstage.c
@@ -38,6 +38,7 @@
 #include <cpu/x86/lapic.h>
 #include <pc80/mc146818rtc.h>
 #include <console/console.h>
+#include <spd.h>
 #include <cpu/amd/model_fxx_rev.h>
 #include "southbridge/broadcom/bcm5785/early_smbus.c"
 #include "northbridge/amd/amdk8/raminit.h"
@@ -77,7 +78,6 @@ static inline int spd_read_byte(unsigned device, unsigned address)
 #include "northbridge/amd/amdk8/coherent_ht.c"
 #include "northbridge/amd/amdk8/raminit_f.c"
 #include "lib/generic_sdram.c"
-#include <spd.h>
 #include "cpu/amd/dualcore/dualcore.c"
 #include "cpu/amd/car/post_cache_as_ram.c"
 #include "cpu/amd/model_fxx/init_cpus.c"
diff --git a/src/mainboard/msi/ms9185/romstage.c b/src/mainboard/msi/ms9185/romstage.c
index 4910fe5..5c3a7c5 100644
--- a/src/mainboard/msi/ms9185/romstage.c
+++ b/src/mainboard/msi/ms9185/romstage.c
@@ -32,6 +32,7 @@
 #include <cpu/x86/lapic.h>
 #include <pc80/mc146818rtc.h>
 #include <console/console.h>
+#include <spd.h>
 #include <cpu/amd/model_fxx_rev.h>
 #include "southbridge/broadcom/bcm5785/early_smbus.c"
 #include "northbridge/amd/amdk8/raminit.h"
@@ -82,7 +83,6 @@ static inline int spd_read_byte(unsigned device, unsigned address)
 #include "lib/generic_sdram.c"
 #include "resourcemap.c"
 #include "cpu/amd/dualcore/dualcore.c"
-#include <spd.h>
 #include "cpu/amd/car/post_cache_as_ram.c"
 #include "cpu/amd/model_fxx/init_cpus.c"
 #include "cpu/amd/model_fxx/fidvid.c"



More information about the coreboot-gerrit mailing list