[coreboot-gerrit] Patch merged into coreboot/master: d3ed411 AMD Trinity boards: Use `sizeof(var)` to get its size

gerrit at coreboot.org gerrit at coreboot.org
Thu May 30 18:04:53 CEST 2013


the following patch was just integrated into master:
commit d3ed411123c9655c6013cb8ed8d3d91cc2dc8c62
Author: Rudolf Marek <r.marek at assembler.cz>
Date:   Sat May 4 00:08:34 2013 +0200

    AMD Trinity boards: Use `sizeof(var)` to get its size
    
    Change `sizeof(type) * n`, where n is the number of array
    elements, to `sizeof(variable)` to directly get the size of the
    variable (struct, array). Determining the size by counting array
    elements is error prone and unnecessary.
    
    Not sure why the copy is needed instead of direct reference.
    Maybe it has something to do with CAR?
    
    These changes are based on Rudolf’s original patch »ASUS F2A85-M:
    Correct and clean up PCIe config« [1], where it was just done for
    the ASUS board.
    
    [1] http://review.coreboot.org/#/c/3194/
    
    Change-Id: I4aa4c6cde5a27b7f335a71afc21d1603f2ae814b
    Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3247
    Tested-by: build bot (Jenkins)
    Reviewed-by: David Hubbard <david.c.hubbard+coreboot at gmail.com>
    Reviewed-by: Bruce Griffith <Bruce.Griffith at se-eng.com>


See http://review.coreboot.org/3247 for details.

-gerrit



More information about the coreboot-gerrit mailing list