[coreboot-gerrit] New patch to review for coreboot: 3fdf58f board_status.sh: trivial cosmetic changes toward the end

[David Hendricks (dhendrix@chromium.org)]

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4051

-gerrit

commit 3fdf58f5d166e937ec9637cf55f9ae804fafdeae
Author: David Hendricks <dhendrix at chromium.org>
Date:   Tue Nov 12 18:17:19 2013 -0800

    board_status.sh: trivial cosmetic changes toward the end
    
    This moves an ugly comment closer to where it is applicable and also
    adds a visual break between the commands which gather data and the
    part of the script that finishes up. I'm usually not fan of banner
    comments, but it seemed to help in my totally subjective opinion.
    
    I was thinking about how to break the part that uploads results into
    a separate function, but there are enough variables that are re-used
    from earlier parts that the tradeoff probably isn't worth it.
    
    Change-Id: If888329911c4de3b907cdf5973695c707bbb02fe
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
---
 util/board_status/board_status.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index 2fb3555..1269c41 100644
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -174,8 +174,9 @@ cmd_nonfatal $REMOTE "cbmem -t" "${tmpdir}/${results}/coreboot_timestamps.txt"
 
 cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"
 
-# FIXME: the board-status directory might get big over time. Is there a way we
-# can push the results without fetching the whole repo?
+#
+# Finish up.
+#
 coreboot_dir=`pwd`
 if [ $UPLOAD_RESULTS -eq 1 ]; then
 	# extract username from ssh://<username>@review.coreboot.org/blah
@@ -183,6 +184,9 @@ if [ $UPLOAD_RESULTS -eq 1 ]; then
 
 	cd "util/board_status/"
 	if [ ! -e "board-status" ]; then
+		# FIXME: the board-status directory might get big over time.
+		# Is there a way we can push the results without fetching the
+		# whole repo?
 		git clone "ssh://${username}@review.coreboot.org:29418/board-status"
 		if [ $? -ne 0 ]; then
 			"Error cloning board-status repo, aborting."