[coreboot-gerrit] Patch merged into coreboot/master: a4affe1 board_status.sh: trivial cosmetic changes toward the end
gerrit at coreboot.org
gerrit at coreboot.org
Sun Nov 17 10:32:24 CET 2013
the following patch was just integrated into master:
commit a4affe17f1a31946841b6fa425d0ef4b3ea00855
Author: David Hendricks <dhendrix at chromium.org>
Date: Tue Nov 12 18:17:19 2013 -0800
board_status.sh: trivial cosmetic changes toward the end
This moves an ugly comment closer to where it is applicable and also
adds a visual break between the commands which gather data and the
part of the script that finishes up. I'm usually not fan of banner
comments, but it seemed to help in my totally subjective opinion.
I was thinking about how to break the part that uploads results into
a separate function, but there are enough variables that are re-used
from earlier parts that the tradeoff probably isn't worth it.
Change-Id: If888329911c4de3b907cdf5973695c707bbb02fe
Signed-off-by: David Hendricks <dhendrix at chromium.org>
Reviewed-on: http://review.coreboot.org/4051
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
See http://review.coreboot.org/4051 for details.
-gerrit
More information about the coreboot-gerrit
mailing list