[coreboot-gerrit] Patch set updated for coreboot: 631d96e Remove CDIT table and DMI table of AMD f15tn and f16kb boards

WANG Siyuan (wangsiyuanbuaa@gmail.com) gerrit at coreboot.org
Mon Nov 18 09:37:06 CET 2013


WANG Siyuan (wangsiyuanbuaa at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4092

-gerrit

commit 631d96e264458ead7c19ecdab95dd107bab24033
Author: WANG Siyuan <wangsiyuanbuaa at gmail.com>
Date:   Mon Nov 18 10:34:06 2013 +0800

    Remove CDIT table and DMI table of AMD f15tn and f16kb boards
    
    There is such kind error:
    ASSERTION FAILED: file 'src/mainboard/asrock/imb-a180/agesawrapper.c',line 431
    DmiTable:100123f7, AcpiPstatein: 10010129,AcpiSrat:0,AcpiSlit:0, Mce:10010de9,Cmc:10010eab,Alib:1002111c, AcpiIvrs:0 in
    agesawrapper_amdinitlate agesawrapper_amdinitlate failed: 5
    
    On f16kb boards, CDIT table and DMI table are failed to created.
    On f15tn boards, DMI table is failed to created.
    
    We remove these tow tables before we find the root cause.
    
    Thank Wei Hu for debugging and founding this issue.
    
    Change-Id: I837e3c322bb5331a9b950a72397796a60642c3f3
    Signed-off-by: WANG Siyuan <SiYuan.Wang at amd.com>
    Signed-off-by: WANG Siyuan <wangsiyuanbuaa at gmail.com>
---
 src/mainboard/amd/olivehill/agesawrapper.c   | 1 -
 src/mainboard/amd/olivehill/buildOpts.c      | 3 ++-
 src/mainboard/amd/parmer/agesawrapper.c      | 1 -
 src/mainboard/amd/parmer/buildOpts.c         | 2 +-
 src/mainboard/amd/thatcher/agesawrapper.c    | 1 -
 src/mainboard/amd/thatcher/buildOpts.c       | 2 +-
 src/mainboard/asrock/imb-a180/agesawrapper.c | 1 -
 src/mainboard/asrock/imb-a180/buildOpts.c    | 3 ++-
 src/mainboard/asus/f2a85-m/agesawrapper.c    | 1 -
 src/mainboard/asus/f2a85-m/buildOpts.c       | 2 +-
 10 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/amd/olivehill/agesawrapper.c b/src/mainboard/amd/olivehill/agesawrapper.c
index f0ad493..8300e34 100644
--- a/src/mainboard/amd/olivehill/agesawrapper.c
+++ b/src/mainboard/amd/olivehill/agesawrapper.c
@@ -427,7 +427,6 @@ agesawrapper_amdinitlate (
 	AmdCreateStruct(&AmdParamStruct);
 	AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
 	Status = AmdInitLate(AmdLateParams);
-	/* CDIT table is not created. */
 	if (Status != AGESA_SUCCESS) {
 		agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
 		ASSERT(Status == AGESA_SUCCESS);
diff --git a/src/mainboard/amd/olivehill/buildOpts.c b/src/mainboard/amd/olivehill/buildOpts.c
index 0528315..ae7f5e9 100644
--- a/src/mainboard/amd/olivehill/buildOpts.c
+++ b/src/mainboard/amd/olivehill/buildOpts.c
@@ -77,7 +77,8 @@
 #define BLDOPT_REMOVE_SLIT                     FALSE //TRUE
 #define BLDOPT_REMOVE_WHEA                     FALSE //TRUE
 #define	BLDOPT_REMOVE_CRAT			TRUE
-//#define BLDOPT_REMOVE_DMI                      FALSE //TRUE
+#define BLDOPT_REMOVE_CDIT                     TRUE
+#define BLDOPT_REMOVE_DMI                      TRUE
 //#define BLDOPT_REMOVE_EARLY_SAMPLES            FALSE
 //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC               TRUE
 //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT               TRUE
diff --git a/src/mainboard/amd/parmer/agesawrapper.c b/src/mainboard/amd/parmer/agesawrapper.c
index 013df13..fcbdded 100644
--- a/src/mainboard/amd/parmer/agesawrapper.c
+++ b/src/mainboard/amd/parmer/agesawrapper.c
@@ -427,7 +427,6 @@ agesawrapper_amdinitlate (
 	AmdCreateStruct(&AmdParamStruct);
 	AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
 	Status = AmdInitLate(AmdLateParams);
-	/* CDIT table is not created. */
 	if (Status != AGESA_SUCCESS) {
 		agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
 		ASSERT(Status == AGESA_SUCCESS);
diff --git a/src/mainboard/amd/parmer/buildOpts.c b/src/mainboard/amd/parmer/buildOpts.c
index d022ae7..1a23190 100644
--- a/src/mainboard/amd/parmer/buildOpts.c
+++ b/src/mainboard/amd/parmer/buildOpts.c
@@ -74,7 +74,7 @@
 #define BLDOPT_REMOVE_SLIT                     FALSE //TRUE
 #define BLDOPT_REMOVE_WHEA                     FALSE //TRUE
 #define	BLDOPT_REMOVE_CRAT			TRUE
-//#define BLDOPT_REMOVE_DMI                      FALSE //TRUE
+#define BLDOPT_REMOVE_DMI                      TRUE
 //#define BLDOPT_REMOVE_EARLY_SAMPLES            FALSE
 //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC               TRUE
 //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT               TRUE
diff --git a/src/mainboard/amd/thatcher/agesawrapper.c b/src/mainboard/amd/thatcher/agesawrapper.c
index 6b71ef64..6331197 100644
--- a/src/mainboard/amd/thatcher/agesawrapper.c
+++ b/src/mainboard/amd/thatcher/agesawrapper.c
@@ -425,7 +425,6 @@ agesawrapper_amdinitlate (
 	AmdCreateStruct(&AmdParamStruct);
 	AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
 	Status = AmdInitLate(AmdLateParams);
-	/* CDIT table is not created. */
 	if (Status != AGESA_SUCCESS) {
 		agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
 		ASSERT(Status == AGESA_SUCCESS);
diff --git a/src/mainboard/amd/thatcher/buildOpts.c b/src/mainboard/amd/thatcher/buildOpts.c
index aace5fd..87f0460 100644
--- a/src/mainboard/amd/thatcher/buildOpts.c
+++ b/src/mainboard/amd/thatcher/buildOpts.c
@@ -74,7 +74,7 @@
 #define BLDOPT_REMOVE_SLIT                     FALSE //TRUE
 #define BLDOPT_REMOVE_WHEA                     FALSE //TRUE
 #define	BLDOPT_REMOVE_CRAT			TRUE
-//#define BLDOPT_REMOVE_DMI                      FALSE //TRUE
+#define BLDOPT_REMOVE_DMI                      TRUE
 //#define BLDOPT_REMOVE_EARLY_SAMPLES            FALSE
 //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC               TRUE
 //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT               TRUE
diff --git a/src/mainboard/asrock/imb-a180/agesawrapper.c b/src/mainboard/asrock/imb-a180/agesawrapper.c
index f0ad493..8300e34 100644
--- a/src/mainboard/asrock/imb-a180/agesawrapper.c
+++ b/src/mainboard/asrock/imb-a180/agesawrapper.c
@@ -427,7 +427,6 @@ agesawrapper_amdinitlate (
 	AmdCreateStruct(&AmdParamStruct);
 	AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
 	Status = AmdInitLate(AmdLateParams);
-	/* CDIT table is not created. */
 	if (Status != AGESA_SUCCESS) {
 		agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
 		ASSERT(Status == AGESA_SUCCESS);
diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c
index d0aae25..7c57183 100644
--- a/src/mainboard/asrock/imb-a180/buildOpts.c
+++ b/src/mainboard/asrock/imb-a180/buildOpts.c
@@ -77,7 +77,8 @@
 #define BLDOPT_REMOVE_SLIT                     FALSE //TRUE
 #define BLDOPT_REMOVE_WHEA                     FALSE //TRUE
 #define	BLDOPT_REMOVE_CRAT			TRUE
-//#define BLDOPT_REMOVE_DMI                      FALSE //TRUE
+#define BLDOPT_REMOVE_CDIT                     TRUE
+#define BLDOPT_REMOVE_DMI                      TRUE
 //#define BLDOPT_REMOVE_EARLY_SAMPLES            FALSE
 //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC               TRUE
 //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT               TRUE
diff --git a/src/mainboard/asus/f2a85-m/agesawrapper.c b/src/mainboard/asus/f2a85-m/agesawrapper.c
index b1d6279..529878b 100644
--- a/src/mainboard/asus/f2a85-m/agesawrapper.c
+++ b/src/mainboard/asus/f2a85-m/agesawrapper.c
@@ -427,7 +427,6 @@ agesawrapper_amdinitlate (
 	AmdCreateStruct(&AmdParamStruct);
 	AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
 	Status = AmdInitLate(AmdLateParams);
-	/* CDIT table is not created. */
 	if (Status != AGESA_SUCCESS) {
 		agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
 		ASSERT(Status == AGESA_SUCCESS);
diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c
index 7f893f9..0091cd9 100644
--- a/src/mainboard/asus/f2a85-m/buildOpts.c
+++ b/src/mainboard/asus/f2a85-m/buildOpts.c
@@ -75,7 +75,7 @@
 #define BLDOPT_REMOVE_SLIT                     FALSE //TRUE
 #define BLDOPT_REMOVE_WHEA                     FALSE //TRUE
 #define	BLDOPT_REMOVE_CRAT			TRUE
-//#define BLDOPT_REMOVE_DMI                      FALSE //TRUE
+#define BLDOPT_REMOVE_DMI                      TRUE
 //#define BLDOPT_REMOVE_EARLY_SAMPLES            FALSE
 //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC               TRUE
 //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT               TRUE



More information about the coreboot-gerrit mailing list