[coreboot-gerrit] New patch to review for coreboot: 584608d qemu: minor bochs cleanups

Gerd Hoffmann (kraxel@redhat.com) gerrit at coreboot.org
Mon Nov 25 19:32:50 CET 2013


Gerd Hoffmann (kraxel at redhat.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4274

-gerrit

commit 584608d53b60343193038aad220be98179e69ac6
Author: Gerd Hoffmann <kraxel at redhat.com>
Date:   Mon Nov 25 17:12:07 2013 +0100

    qemu: minor bochs cleanups
    
    Add a comment, tweak spacing a bit, addr variable
    doesn't need to be global any more.
    
    Change-Id: Id8d8a7babce671243351074f7ac52a5c8c264de5
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
---
 src/drivers/emulation/qemu/bochs.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/drivers/emulation/qemu/bochs.c b/src/drivers/emulation/qemu/bochs.c
index eb11e34..b4acfef 100644
--- a/src/drivers/emulation/qemu/bochs.c
+++ b/src/drivers/emulation/qemu/bochs.c
@@ -41,7 +41,6 @@
 
 static int width  = CONFIG_DRIVERS_EMULATION_QEMU_BOCHS_XRES;
 static int height = CONFIG_DRIVERS_EMULATION_QEMU_BOCHS_YRES;
-static u32 addr   = 0;
 
 static void bochs_write(int index, int val)
 {
@@ -57,7 +56,9 @@ static int bochs_read(int index)
 
 static void bochs_init(device_t dev)
 {
+	struct edid edid;
 	int id, mem, bar;
+	u32 addr;
 
 	/* bochs dispi detection */
 	id = bochs_read(VBE_DISPI_INDEX_ID);
@@ -101,7 +102,8 @@ static void bochs_init(device_t dev)
 		    VBE_DISPI_ENABLED | VBE_DISPI_LFB_ENABLED);
 
 	outb(0x20, 0x3c0); /* disable blanking */
-	struct edid edid;
+
+	/* setup coreboot framebuffer */
 	edid.ha = width;
 	edid.va = height;
 	edid.bpp = 32;



More information about the coreboot-gerrit mailing list