[coreboot-gerrit] Patch merged into coreboot/master: 8c59477 cbmem utility: compatibility with older coreboot versions
gerrit at coreboot.org
gerrit at coreboot.org
Mon Nov 25 23:02:09 CET 2013
the following patch was just integrated into master:
commit 8c5947709a1d9e72d6ce17c48068b38afcb81967
Author: Stefan Reinauer <reinauer at chromium.org>
Date: Fri Apr 19 14:22:29 2013 -0700
cbmem utility: compatibility with older coreboot versions
Commit b8ad224 changed the memory address in lb_cbmem_ref coreboot
table entries from a pointer to a uint64_t. This change was introduced
to make the cbmem utility work on both 32bit and 64bit userland.
Unfortunately, this broke the cbmem utility running on older versions
of coreboot because they were still providing a 32bit only field for
the address while the cbmem utility would now take the following 4
bytes as upper 32bits of a pointer that can obviously not be
mmapped. This change checks if the size of the lb_cbmem_ref structure
provided by coreboot is smaller than expected, and if so, ignore the
upper 32bit of the address read.
Signed-off-by: Stefan Reinauer <reinauer at google.com>
Change-Id: If4c8e9b72b2a38c961c11d7071b728e61e5f1d18
Commit-Queue: Stefan Reinauer <reinauer at google.com>
Tested-by: Stefan Reinauer <reinauer at google.com>
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-on: http://review.coreboot.org/4139
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
See http://review.coreboot.org/4139 for details.
-gerrit
More information about the coreboot-gerrit
mailing list