[coreboot-gerrit] Patch merged into coreboot/master: 4d7a4c5 x86: use proper types for interrupt callbacks

gerrit at coreboot.org gerrit at coreboot.org
Mon Nov 25 23:05:11 CET 2013


the following patch was just integrated into master:
commit 4d7a4c59dea4cc5f31d9bdd8163f3e0c925b1e90
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Apr 23 10:25:34 2013 -0500

    x86: use proper types for interrupt callbacks
    
    The mainboard_interrupt_handlers() argument for the function
    pointer was using void * as the type. This does not allow the compiler
    to catch type differences for the arguments. Thus, some code has been
    committed which violates the new interrupt callbacks not taking any
    arguments. Make sure the compiler provides a type checking benefit.
    
    Change-Id: Ie20699a368e70c33a9a9912e0fcd63f1e6bb4f18
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/48970
    Reviewed-on: http://review.coreboot.org/4141
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>


See http://review.coreboot.org/4141 for details.

-gerrit



More information about the coreboot-gerrit mailing list