[coreboot-gerrit] Patch merged into coreboot/master: d7cb8d0 lynxpoint: Change SerialIO device enable reporting to ACPI

gerrit at coreboot.org gerrit at coreboot.org
Mon Nov 25 23:28:29 CET 2013


the following patch was just integrated into master:
commit d7cb8d074f4a9e437ed897ac596ca794698b38c9
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed May 15 15:03:57 2013 -0700

    lynxpoint: Change SerialIO device enable reporting to ACPI
    
    In order to report whether coreboot enabled a SerialIO device
    in ACPI mode we had been relying on reading NVS in the _STA
    method for the SerialIO device.
    
    The ACPI _STA method has restrictions on what it can access
    and is unable to access OperationRegions outside its scope
    which means it should not be trying to read NVS.
    
    This change adds a new SSDT to the ACPI tables and fills it
    with constants that indicate whether or not a device is enabled
    in ACPI mode.
    
    The ACPI code is changed to read these variables from the
    SSDT and use that instead of trying to query a variable in NVS.
    
    Attempt to use lpt-clk driver to probe the
    device clocks for SerialIO devices and see that the kernel
    does not complain about accessing the GNVS region.
    
    Change-Id: I8538bee4390daed4ecca679496ab0cb313f174ce
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/51369
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/4170
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>


See http://review.coreboot.org/4170 for details.

-gerrit



More information about the coreboot-gerrit mailing list