[coreboot-gerrit] Patch merged into coreboot/master: 619eca0 lynxpoint: fix mem corruption during ssdt2 gen

gerrit at coreboot.org gerrit at coreboot.org
Mon Nov 25 23:37:33 CET 2013


the following patch was just integrated into master:
commit 619eca0685ef2c7777ff0d741730a29af5db05a0
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed May 22 15:28:20 2013 -0500

    lynxpoint: fix mem corruption during ssdt2 gen
    
    The ssdt2 generation code was calling acpigen_patch_len().
    However, none of the entries had AML object lengths that
    needed patching. That resulted in the following message:
    
    ASSERTION FAILED: file 'src/arch/x86/boot/acpigen.c',  line 52
    
    Additionally, this caused an errant write to a memory address
    whose value was in the variable ltop. This was the 0 address.
    
    Change-Id: I44abf5a4e4225220575aee6b5c9bb6b0be093a28
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/56299
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-by: Stefan Reinauer <reinauer at google.com>
    Reviewed-on: http://review.coreboot.org/4182
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>


See http://review.coreboot.org/4182 for details.

-gerrit



More information about the coreboot-gerrit mailing list