[coreboot-gerrit] New patch to review for coreboot: 90d6964 Fix compile errors in AMD Fam16 AGESA code with gcc 4.5.

Wei Hu (wei@aristanetworks.com) gerrit at coreboot.org
Wed Sep 4 12:04:17 CEST 2013


Wei Hu (wei at aristanetworks.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3899

-gerrit

commit 90d6964901e3082ae78fc6face3a38048839dda8
Author: Wei Hu <wei at aristanetworks.com>
Date:   Wed Sep 4 03:01:45 2013 -0700

    Fix compile errors in AMD Fam16 AGESA code with gcc 4.5.
    
    Change-Id: I27f5b8d5d0e5559e06bf8bddbeefe24bfe71c384
    Signed-off-by: Wei Hu <wei at aristanetworks.com>
---
 src/include/usbdebug.h                                   | 1 -
 src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuHtc.h | 4 ++--
 src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuPsi.h | 4 ++--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/include/usbdebug.h b/src/include/usbdebug.h
index 926d658..36fd9cf 100644
--- a/src/include/usbdebug.h
+++ b/src/include/usbdebug.h
@@ -24,7 +24,6 @@
 #define EHCI_BAR_INDEX		0x10
 #define PCI_EHCI_CLASSCODE 	0x0c0320	/* USB2.0 with EHCI controller */
 
-typedef u32 pci_devfn_t;
 pci_devfn_t pci_ehci_dbg_dev(unsigned hcd_idx);
 unsigned long pci_ehci_base_regs(pci_devfn_t dev);
 void pci_ehci_dbg_set_port(pci_devfn_t dev, unsigned int port);
diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuHtc.h b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuHtc.h
index 913802f..38d7d16 100644
--- a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuHtc.h
+++ b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuHtc.h
@@ -114,12 +114,12 @@ typedef F_HTC_INIT *PF_HTC_INIT;
  * Each supported Family must provide an implementation for all methods in this interface, even if the
  * implementation is a CommonReturn().
  */
-typedef struct _HTC_FAMILY_SERVICES {
+struct _HTC_FAMILY_SERVICES {
   UINT16          Revision;                                             ///< Interface version
   // Public Methods.
   PF_HTC_IS_SUPPORTED IsHtcSupported;                                   ///< Method: Family specific call to check if HTC is supported.
   PF_HTC_INIT         EnableHtcOnSocket;                                ///< Method: Family specific call to enable HTC.
-} HTC_FAMILY_SERVICES;
+};
 
 
 /*----------------------------------------------------------------------------------------
diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuPsi.h b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuPsi.h
index ad2a5e5..44f3837 100644
--- a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuPsi.h
+++ b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuPsi.h
@@ -114,12 +114,12 @@ typedef F_PSI_INIT *PF_PSI_INIT;
  * Each supported Family must provide an implementation for all methods in this interface, even if the
  * implementation is a CommonReturn().
  */
-typedef struct _PSI_FAMILY_SERVICES {
+struct _PSI_FAMILY_SERVICES {
   UINT16          Revision;                                             ///< Interface version
   // Public Methods.
   PF_PSI_IS_SUPPORTED IsPsiSupported;                                   ///< Method: Family specific call to check if PSI is supported.
   PF_PSI_INIT         EnablePsiOnSocket;                                ///< Method: Family specific call to enable PSI.
-} PSI_FAMILY_SERVICES;
+};
 
 
 /*----------------------------------------------------------------------------------------



More information about the coreboot-gerrit mailing list