[coreboot-gerrit] Patch merged into coreboot/master: d78ff54 hp/pavilion_m6_1035dx: Sanitize #includes

gerrit at coreboot.org gerrit at coreboot.org
Thu Apr 3 20:19:28 CEST 2014


the following patch was just integrated into master:
commit d78ff54110c6216a1800fc2f62cf85701a171587
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Fri Mar 28 14:48:13 2014 -0500

    hp/pavilion_m6_1035dx: Sanitize #includes
    
    There were a number of things wrong with the includes. First, The
    includes did not use paths to AGESA files, thus relying on the
    compiler include paths to find the correct file. This made it unclear
    where the file included was located, and whether it was local, under
    vendorcode, or under a different directory. Instead, use full paths
    for each non-local include.
    
    Second, the local includes were mixed with the rest, making it unclear
    which file is local and which one is not. Keep the local includes at
    the top. This also prevents us from polluting the namespace of local
    headers, with library definitions, and allows us to catch if we missed
    an otherwise needed external header.
    
    Thirdly, alphabetize the order of includes where possible.
    
    Change-Id: I22c543291beabb83c16d912ea0a490be6ca4e03c
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>


See http://review.coreboot.org/5412 for details.

-gerrit



More information about the coreboot-gerrit mailing list