[coreboot-gerrit] Patch set updated for coreboot: d0f7cf7 ec/compal/ene932/acpi: Let mainboard define the ACPI lid object

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Sun Apr 6 02:30:01 CEST 2014


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5444

-gerrit

commit d0f7cf78e55be565638dd870042d13646b6e23ab
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Tue Apr 1 16:02:08 2014 -0500

    ec/compal/ene932/acpi: Let mainboard define the ACPI lid object
    
    The GP15 ACPI object was used to get the state of the lid. However
    GP15 is specific to certain Intel chipsets, and will not always be in
    the ACPI namespace. Instead of hardcoding this object, let the
    mainboard define it.
    
    Change-Id: I02a2eb3116af61ea5701f84507327aa40218597a
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/ec/compal/ene932/acpi/ec.asl        | 2 +-
 src/mainboard/google/parrot/acpi/ec.asl | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/ec/compal/ene932/acpi/ec.asl b/src/ec/compal/ene932/acpi/ec.asl
index cb50a21..a042d75 100644
--- a/src/ec/compal/ene932/acpi/ec.asl
+++ b/src/ec/compal/ene932/acpi/ec.asl
@@ -273,7 +273,7 @@ Device (EC0)
 		Store (ADPT, \PWRS)
 
 		// Initialize LID switch state
-		Store (GP15, \LIDS)
+		Store (EC_ACPI_LID_SWITCH_OBJECT, \LIDS)
 
 		// Force a read of CPU temperature
 		Store (CTML, Local0)
diff --git a/src/mainboard/google/parrot/acpi/ec.asl b/src/mainboard/google/parrot/acpi/ec.asl
index 522a0b9..a0ee9d5 100644
--- a/src/mainboard/google/parrot/acpi/ec.asl
+++ b/src/mainboard/google/parrot/acpi/ec.asl
@@ -21,5 +21,8 @@
 #include "../ec.h"
 #define EC_SCI 23      // GPIO7 << 16 to GPE bit for Runtime SCI
 
+/* GP15 is defined in the southbridge's ASL */
+#define EC_ACPI_LID_SWITCH_OBJECT	GP15
+
 /* ACPI code for EC functions */
 #include "../../../../ec/compal/ene932/acpi/ec.asl"



More information about the coreboot-gerrit mailing list