[coreboot-gerrit] Patch merged into coreboot/master: 8395e90 supermicro/h8qgi/dsdt: Use PIC as default interrupt model

gerrit at coreboot.org gerrit at coreboot.org
Wed Apr 9 20:52:17 CEST 2014


the following patch was just integrated into master:
commit 8395e90bc0a737f09ef5b5e2c94e37c66748b505
Author: Konstantin Aladyshev <aladyshev at nicevt.ru>
Date:   Sat Jul 12 02:36:32 2014 +0400

    supermicro/h8qgi/dsdt: Use PIC as default interrupt model
    
    According ACPI specification:
    
    """
    The \_PIC optional method is used to report to the BIOS the current
    interrupt model used by the OS. The argument passed into the method
    signifies the interrupt model OSPM has chosen, PIC mode, APIC mode,
    or SAPIC mode. Notice that calling this method is optional for OSPM.
    If the method is never called, the BIOS must assume PIC mode.
    
    Arguments: (1)
    Arg0 – An Integer containing a code for the current interrupt model:
    0 –PIC mode
    1 –APIC mode
    2 –SAPIC mode
    """
    
    In current configuration with default value of interrupt model
    PMOD equal 1 (APIC mode), Linux can't boot with "noapic" option.
    Kernel never call _PIC method and PMOD stays equal 1, indicatind
    that APIC routing objects should be evaluated. This mix of PIC
    and APIC leads to boot fail.
    
    Change default value of interrupt model PMOD to 0, for correct
    "noapic" boot.
    
    Change-Id: I7fa6f0c24802751202ed2e7f13411001a600e772
    Signed-off-by: Konstantin Aladyshev <aladyshev at nicevt.ru>
    Reviewed-on: http://review.coreboot.org/5473
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>


See http://review.coreboot.org/5473 for details.

-gerrit



More information about the coreboot-gerrit mailing list