[coreboot-gerrit] Patch set updated for coreboot: 79d6d9e driver/elog: Fix implicit function declaration issue

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Apr 15 07:59:24 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5504

-gerrit

commit 79d6d9ead40b25dac6a8eb76266e79484c8d9937
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Apr 15 14:32:53 2014 +1000

    driver/elog: Fix implicit function declaration issue
    
    Fix compilation. Relying on the pre-processor to condition a if
    statement will lead to warnings of implicititly defined functions.
    
    Change-Id: Id0117528c5579cc1dec750a8a17a76fab4314b3f
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/drivers/elog/elog.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c
index de34928..4b1f839 100644
--- a/src/drivers/elog/elog.c
+++ b/src/drivers/elog/elog.c
@@ -607,12 +607,15 @@ int elog_init(void)
 
 #if !defined(__SMM__)
 	/* Log boot count event except in S3 resume */
-	if (CONFIG_ELOG_BOOT_COUNT && acpi_slp_type != 3)
+#if CONFIG_ELOG_BOOT_COUNT == 1
+	if (acpi_slp_type != 3)
 		elog_add_event_dword(ELOG_TYPE_BOOT, boot_count_read());
+#endif /* CONFIG_ELOG_BOOT_COUNT */
 
 	/* Check and log POST codes from previous boot */
-	if (CONFIG_CMOS_POST)
-		cmos_post_log();
+#if CONFIG_CMOS_POST == 1
+	cmos_post_log();
+#endif /* CONFIG_CMOS_POST */
 #endif
 
 	return 0;



More information about the coreboot-gerrit mailing list