[coreboot-gerrit] Patch set updated for coreboot: d9f7b98 driver/elog: Fix implicit function declaration issue

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Apr 15 08:43:53 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5504

-gerrit

commit d9f7b98b90dd7d7a6848c517131a2538875b6f1f
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Apr 15 14:32:53 2014 +1000

    driver/elog: Fix implicit function declaration issue
    
    Fix compilation. Relying on the pre-processor to condition a if
    statement will lead to warnings of implicititly defined functions.
    To solve this dillemma add symbols to resolve to at compile time.
    
    Change-Id: Id0117528c5579cc1dec750a8a17a76fab4314b3f
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/include/elog.h             | 4 +++-
 src/include/pc80/mc146818rtc.h | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/include/elog.h b/src/include/elog.h
index f9b5d53..73466e8 100644
--- a/src/include/elog.h
+++ b/src/include/elog.h
@@ -162,7 +162,9 @@ extern u32 gsmi_exec(u8 command, u32 *param);
 #if CONFIG_ELOG_BOOT_COUNT
 u32 boot_count_read(void);
 u32 boot_count_increment(void);
-#endif
+#else
+static inline u32 boot_count_read(void) {}
+#endif /* CONFIG_ELOG_BOOT_COUNT */
 
 #endif /* !CONFIG_ELOG */
 
diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h
index fd40308..cf4a951 100644
--- a/src/include/pc80/mc146818rtc.h
+++ b/src/include/pc80/mc146818rtc.h
@@ -220,6 +220,8 @@ static inline enum cb_err get_option(void *dest __attribute__((unused)),
 #define CMOS_POST_EXTRA_DEV_PATH  0x01
 
 void cmos_post_log(void);
+#else
+static inline void cmos_post_log(void) {}
 #endif /* CONFIG_CMOS_POST */
 
 #endif /*  PC80_MC146818RTC_H */



More information about the coreboot-gerrit mailing list