[coreboot-gerrit] New patch to review for coreboot: 06c293d mainboard/jetway/nf81-t56n-lf: Make ACPI debug menuconfigable

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Apr 15 09:29:26 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5506

-gerrit

commit 06c293df959a0a5c4c65fc52d863e7ab0462883e
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Apr 15 17:26:46 2014 +1000

    mainboard/jetway/nf81-t56n-lf: Make ACPI debug menuconfigable
    
    Turns out we have a CONFIG_DEBUG_ACPI definition under:
    Debugging -> Output verbose ACPI debug messages
    Hence, let us make use of this definition.
    
    Change-Id: I1b673feb6d9b2ee51c832a1cef159cd80e5c3517
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c b/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c
index b513fce..a3c5728 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c
+++ b/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c
@@ -28,8 +28,7 @@
 #include <device/pci_ids.h>
 #include <string.h>
 
-#define DUMP_ACPI_TABLES 0
-#include <lib.h> /* used for hexdump for DUMP_ACPI_TABLES */
+#include <lib.h> /* used for hexdump for CONFIG_DEBUG_ACPI */
 
 extern const unsigned char AmlCode[];
 
@@ -268,7 +267,7 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt2->length;
 	acpi_add_table(rsdp,ssdt2);
 
-#if DUMP_ACPI_TABLES == 1
+#if defined(CONFIG_DEBUG_ACPI)
 	printk(BIOS_DEBUG, "rsdp\n");
 	hexdump(rsdp, sizeof(acpi_rsdp_t));
 
@@ -298,7 +297,7 @@ unsigned long write_acpi_tables(unsigned long start)
 
 	printk(BIOS_DEBUG, "hest\n");
 	hexdump(hest, hest->header.length);
-#endif /* DUMP_ACPI_TABLES */
+#endif /* CONFIG_DEBUG_ACPI */
 
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;



More information about the coreboot-gerrit mailing list