[coreboot-gerrit] New patch to review for coreboot: 406c959 superio/ite/it8661f: Make early_serial into romstage sym

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Apr 15 12:35:34 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5508

-gerrit

commit 406c95991c196086b0beeff30895dc891a1b3100
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Apr 15 20:30:49 2014 +1000

    superio/ite/it8661f: Make early_serial into romstage sym
    
    Following similar reasoning as commit:
    d304331 superio/fintek/f81865f: Avoid .c includes
    
    Avoid any mistaken future inclusion of early_serial.c in mainboard.c
    code by providing symbols in romstage.
    
    Change-Id: I9e763a7ad9de090e35acdcf4d6a280d8227c6015
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/superio/ite/it8661f/Makefile.inc   | 2 +-
 src/superio/ite/it8661f/early_serial.c | 3 ++-
 src/superio/ite/it8661f/it8661f.h      | 8 +++++---
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/superio/ite/it8661f/Makefile.inc b/src/superio/ite/it8661f/Makefile.inc
index f6f30db..af4e878 100644
--- a/src/superio/ite/it8661f/Makefile.inc
+++ b/src/superio/ite/it8661f/Makefile.inc
@@ -18,5 +18,5 @@
 ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
 ##
 
+romstage-$(CONFIG_SUPERIO_ITE_IT8661F) += early_serial.c
 ramstage-$(CONFIG_SUPERIO_ITE_IT8661F) += superio.c
-
diff --git a/src/superio/ite/it8661f/early_serial.c b/src/superio/ite/it8661f/early_serial.c
index ee132fa..7373f71 100644
--- a/src/superio/ite/it8661f/early_serial.c
+++ b/src/superio/ite/it8661f/early_serial.c
@@ -19,6 +19,7 @@
  */
 
 #include <arch/io.h>
+#include <device/pnp.h>
 #include "it8661f.h"
 
 /* Perform MB PnP setup to put the SIO chip at 0x3f0. */
@@ -68,7 +69,7 @@ static void it8661f_set_clkin(device_t dev, u8 clkin)
 	pnp_exit_ext_func_mode(dev);
 }
 
-static void it8661f_enable_serial(device_t dev, u16 iobase)
+void it8661f_enable_serial(device_t dev, u16 iobase)
 {
 	pnp_enter_ext_func_mode(dev);
 	pnp_set_logical_device(dev);
diff --git a/src/superio/ite/it8661f/it8661f.h b/src/superio/ite/it8661f/it8661f.h
index 5a51f02..045a54c 100644
--- a/src/superio/ite/it8661f/it8661f.h
+++ b/src/superio/ite/it8661f/it8661f.h
@@ -18,8 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
-#ifndef SUPERIO_ITE_IT8661F_IT8661F_H
-#define SUPERIO_ITE_IT8661F_IT8661F_H
+#ifndef SUPERIO_ITE_IT8661F_H
+#define SUPERIO_ITE_IT8661F_H
 
 /* Datasheet: http://www.ite.com.tw/product_info/PC/Brief-IT8661_2.asp */
 
@@ -52,4 +52,6 @@ static const u8 init_values[] = {
 	0xe8, 0x74, 0x3a, 0x9d, /**/ 0xce, 0xe7, 0x73, 0x39,
 };
 
-#endif
+void it8661f_enable_serial(device_t dev, u16 iobase);
+
+#endif /* SUPERIO_ITE_IT8661F_H */



More information about the coreboot-gerrit mailing list