[coreboot-gerrit] Patch merged into coreboot/master: 73639e2 hp/pavilion_m6_1035dx: Add SMI handler and handle EC requests

gerrit at coreboot.org gerrit at coreboot.org
Thu Apr 17 16:48:59 CEST 2014


the following patch was just integrated into master:
commit 73639e27170355a2bb9a54a340f5bcd2f3dac161
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Apr 9 12:24:39 2014 -0500

    hp/pavilion_m6_1035dx: Add SMI handler and handle EC requests
    
    The EC may disable some functionality, such as Caps Lock LED and
    battery charging if it never receives a command to go in APM mode. If
    we start it in APM mode, then immediately switch to ACPI mode, it will
    not get its SCIs serviced until an ACPI OS boots. If its SCIs are not
    serviced, it may assume the OS has hung.
    
    The way we solve this is to initalize the EC in APM mode, and only
    switch it to ACPI when an ACPI-capable OS issues the ACPI_ENABLE
    command. The switch has to be handled in SMM.
    
    Although we aren't yet processing SMIs from the EC, we are reading the
    status in order to satisfy the EC that the event is handled.
    
    Change-Id: Iffaeb9a6f57841f456c4bce8337dc09b287f8758
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
    Reviewed-on: http://review.coreboot.org/5512
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Aaron Durbin <adurbin at gmail.com>


See http://review.coreboot.org/5512 for details.

-gerrit



More information about the coreboot-gerrit mailing list