[coreboot-gerrit] Patch set updated for coreboot: d76d5e5 util/xcompile/xcompile: Remove `-Wno-unused-but-set-variable` from `CFLAGS`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Fri Apr 18 16:42:27 CEST 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3981

-gerrit

commit d76d5e543f4455d96e84605dd2648e6135260a1e
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Oct 20 00:11:34 2013 +0200

    util/xcompile/xcompile: Remove `-Wno-unused-but-set-variable` from `CFLAGS`
    
    Do not disable warnings about unused but set variables to further
    improve the code quality.
    
    Change-Id: I25fa29ac42c9d09596d03f11fb01f31635a62a11
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 util/xcompile/xcompile | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index df7d558..bfb6da1 100644
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -89,11 +89,6 @@ testas() {
 
 detect_special_flags() {
 	local architecture="$1"
-	# GCC 4.6 is much more picky about unused variables.
-	# Turn off it's warnings for now:
-	testcc "$CC"   "$CFLAGS -Wno-unused-but-set-variable " &&
-		CFLAGS="$CFLAGS -Wno-unused-but-set-variable "
-
 	# Use bfd linker instead of gold if available:
 	testcc "$CC"   "$CFLAGS -fuse-ld=bfd" &&
 		CFLAGS="$CFLAGS -fuse-ld=bfd" && LINKER_SUFFIX='.bfd'



More information about the coreboot-gerrit mailing list