[coreboot-gerrit] New patch to review for coreboot: 46844ee hp/pavilion_m6_1035dx: Move GEVENT/GPE definitions to common file
Alexandru Gagniuc (mr.nuke.me@gmail.com)
gerrit at coreboot.org
Sat Apr 19 04:05:00 CEST 2014
Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5547
-gerrit
commit 46844ee5956bb06221d8eae29a907704bf65b74a
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date: Fri Apr 18 19:53:51 2014 -0500
hp/pavilion_m6_1035dx: Move GEVENT/GPE definitions to common file
These definitions were scattered in a couple of files, and we risk
scattering them all over the place. Provide a common file for these
definitions.
Change-Id: I1fe99e5097cf10a349661f3b2ae2377f5cdd6103
Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl | 6 ++----
src/mainboard/hp/pavilion_m6_1035dx/ec.h | 3 +--
src/mainboard/hp/pavilion_m6_1035dx/mainboard.h | 22 ++++++++++++++++++++++
3 files changed, 25 insertions(+), 6 deletions(-)
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl
index 188515c..0293a12 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl
+++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl
@@ -3,10 +3,8 @@
* Subject to the GNU GPL v2, or (at your option) any later version.
*/
-/*
- * EC bits specific to the mainboard
- */
-#define EC_SCI_GPE 3
+/* Defines EC bits specific to the mainboard, needed by EC ASL */
+#include "mainboard.h"
/* ACPI code for EC functions */
#include <ec/compal/ene932/acpi/ec.asl>
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/ec.h b/src/mainboard/hp/pavilion_m6_1035dx/ec.h
index 7eb4d06..61ecc06 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/ec.h
+++ b/src/mainboard/hp/pavilion_m6_1035dx/ec.h
@@ -6,8 +6,7 @@
#ifndef _MAINBOARD_HP_PAVILION_M6_1035DX_EC_H
#define _MAINBOARD_HP_PAVILION_M6_1035DX_EC_H
-#define EC_SMI_GEVENT 23
-#define EC_LID_GEVENT 22
+#include "mainboard.h"
#ifndef __SMM__
void pavilion_m6_1035dx_ec_init(void);
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mainboard.h b/src/mainboard/hp/pavilion_m6_1035dx/mainboard.h
new file mode 100644
index 0000000..1e69cc9
--- /dev/null
+++ b/src/mainboard/hp/pavilion_m6_1035dx/mainboard.h
@@ -0,0 +1,22 @@
+/*
+ * "The way things are connected" and a few setup options
+ *
+ * Copyright (C) 2014 Alexandru Gagniuc <mr.nuke.me at gmail.com>
+ * Subject to the GNU GPL v2, or (at your option) any later version.
+ */
+
+#ifndef _MAINBOARD_HP_PAVILION_M6_1035DX_MAINBOARD_H
+#define _MAINBOARD_HP_PAVILION_M6_1035DX_MAINBOARD_H
+
+/* What is connected to GEVENT pins */
+#define EC_SCI_GEVENT 3
+#define EC_LID_GEVENT 22
+#define EC_SMI_GEVENT 23
+
+/* Any GEVENT pin can be mapped to any GPE. We try to keep the mapping 1:1, but
+ * we make the distinction between GEVENT pin and SCI.
+ */
+#define EC_SCI_GPE EC_SCI_GEVENT
+
+
+#endif /* _MAINBOARD_HP_PAVILION_M6_1035DX_MAINBOARD_H */
More information about the coreboot-gerrit
mailing list