[coreboot-gerrit] Patch merged into coreboot/master: a6c525a AMD AGESA cimx/sb700: Drop APIC_ID_OFFSET and MAX_PHYSICAL_CPUS

gerrit at coreboot.org gerrit at coreboot.org
Sun Apr 20 20:03:57 CEST 2014


the following patch was just integrated into master:
commit a6c525a7d5ad0dedc31dcc9719be6bc5fbc743dd
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Wed Apr 16 09:43:40 2014 +0300

    AMD AGESA cimx/sb700: Drop APIC_ID_OFFSET and MAX_PHYSICAL_CPUS
    
    Following boards use cimx/sb700:
      amd/dinar
      supermicro/h8qgi
      supermicro/h8scm
      tyan/s8226
    
    Only amd/dinar had APIC_ID_OFFSET defined, thus all had 0x0.
    There was a nonsense preprocessor directive (MAX_CPUS * MAX_PHYSICAL_CPUS >= 1).
    
    Except for tyan, (MAX_CPUS * MAX_PHYSICAL_CPUS) % 256 == 0.
    Together with documented 4-bit restriction for APIC ID field, this APIC ID
    programming matches with MP tables and ACPI tables.
    
    I believe this would also fix cases of cimx/sb700 with MAX_CPUS<16, which
    we do not have in the tree.
    
    Change-Id: If8d65e95788ba02fc8d331a7af03a4d0d8cf5c69
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
    Reviewed-on: http://review.coreboot.org/5539
    Tested-by: build bot (Jenkins)
    Reviewed-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>


See http://review.coreboot.org/5539 for details.

-gerrit



More information about the coreboot-gerrit mailing list