[coreboot-gerrit] Patch set updated for coreboot: 45f2b36 drivers/pc80/Kconfig: Do not init PS/2 keyboard if SeaBIOS is chosen as payload

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sat Apr 26 20:45:17 CEST 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5581

-gerrit

commit 45f2b36beb987628ede95126e5fe69bca5e03e8c
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat Apr 26 10:18:12 2014 +0200

    drivers/pc80/Kconfig: Do not init PS/2 keyboard if SeaBIOS is chosen as payload
    
    As the Kconfig description of `DRIVERS_PS2_KEYBOARD` says, SeaBIOS is
    able to initialize the PS/2 keyboard itself, so it is not necessary to
    let coreboot do it.
    
    SeaBIOS is also able to do it faster as discussed in a thread on the
    coreboot mailing list from October 2010 [1]. In that thread it was
    also proposed to not let coreboot initialize the PS/2 coreboot when
    SeaBIOS is used as a payload.
    
    [1] http://www.coreboot.org/pipermail/coreboot/2010-October/thread.html#61310
        subject: [coreboot] coreboot+seabios timings
    
    Change-Id: I1248cec3e2ca5b9311e46df8aabf67e14ffd4ea6
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/drivers/pc80/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/drivers/pc80/Kconfig b/src/drivers/pc80/Kconfig
index 3c8fd8c..acd1503 100644
--- a/src/drivers/pc80/Kconfig
+++ b/src/drivers/pc80/Kconfig
@@ -2,7 +2,8 @@
 # reliably support PS/2 init themselves.
 config DRIVERS_PS2_KEYBOARD
 	bool "PS/2 keyboard init"
-	default y
+	default n if PAYLOAD_SEABIOS
+	default y if !PAYLOAD_SEABIOS
 	help
 	  Enable this option to initialize PS/2 keyboards found connected
 	  to the PS/2 port.



More information about the coreboot-gerrit mailing list