[coreboot-gerrit] Patch set updated for coreboot: 762d3e0 util/cbfstool: Use `%zu` instead of `%ld` for size_t arguments

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Mon Apr 28 17:05:26 CEST 2014


Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5388

-gerrit

commit 762d3e055bd8099f1f9de98499fb2ed39c93a290
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Mar 16 00:15:57 2014 +0100

    util/cbfstool: Use `%zu` instead of `%ld` for size_t arguments
    
    cbfstool fails to built under 32-bit platforms since commit
    
        aa2f739a cbfs: fix issues with word size and endianness.
    
    due to the use of '%ld' format specifier on size_t, which on these
    platforms is only 32-bit.
    
    Use the length modifier `z` for size_t arguments, and cast to size_t where appropriate.
    
    Change-Id: Id84a20fbf237376a31f7e4816bd139463800c977
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 util/cbfstool/cbfs-mkstage.c | 4 ++--
 util/cbfstool/elfheaders.c   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/util/cbfstool/cbfs-mkstage.c b/util/cbfstool/cbfs-mkstage.c
index 6aa3746..2a92c9f 100644
--- a/util/cbfstool/cbfs-mkstage.c
+++ b/util/cbfstool/cbfs-mkstage.c
@@ -132,8 +132,8 @@ int parse_elf_to_stage(const struct buffer *input, struct buffer *output,
 			continue;
 		if (input->size < (phdr[i].p_offset + phdr[i].p_filesz)){
 			ERROR("Underflow copying out the segment."
-			      "File has %ld bytes left, segment end is %ld\n",
-			      input->size, phdr[i].p_offset + phdr[i].p_filesz);
+			      "File has %zu bytes left, segment end is %zu\n",
+			      input->size, (size_t)(phdr[i].p_offset + phdr[i].p_filesz));
 			return -1;
 		}
 		memcpy(buffer + (l_start - data_start),
diff --git a/util/cbfstool/elfheaders.c b/util/cbfstool/elfheaders.c
index d217aac..5b5cf94 100644
--- a/util/cbfstool/elfheaders.c
+++ b/util/cbfstool/elfheaders.c
@@ -147,7 +147,7 @@ check_size(const struct buffer *b, size_t offset, size_t size, const char *desc)
 
 	if (offset >= buffer_size(b) || (offset + size) > buffer_size(b)) {
 		ERROR("The file is not large enough for the '%s'. "
-		      "%ld bytes @ offset %zu, input %zu bytes.\n",
+		      "%zu bytes @ offset %zu, input %zu bytes.\n",
 		      desc, size, offset, buffer_size(b));
 		return -1;
 	}



More information about the coreboot-gerrit mailing list