[coreboot-gerrit] New patch to review for coreboot: 3a5e269 superio/winbond/w83627thg: Remove w83627thg_enable_serial symbol

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Apr 29 06:06:28 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5604

-gerrit

commit 3a5e2690675c186e33980038c0b3e078ed999a86
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Apr 29 14:05:02 2014 +1000

    superio/winbond/w83627thg: Remove w83627thg_enable_serial symbol
    
    Remove model specific implementation, w83627thg_enable_serial, from
    romstage component of sio support.
    
    Change-Id: I8ef1de5ccccae5f4dba69dbdb939e7070d3cecfc
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/superio/winbond/w83627thg/early_serial.c | 10 ----------
 src/superio/winbond/w83627thg/w83627thg.h    |  1 -
 2 files changed, 11 deletions(-)

diff --git a/src/superio/winbond/w83627thg/early_serial.c b/src/superio/winbond/w83627thg/early_serial.c
index cc84738..6ab178b 100644
--- a/src/superio/winbond/w83627thg/early_serial.c
+++ b/src/superio/winbond/w83627thg/early_serial.c
@@ -37,16 +37,6 @@ void pnp_exit_ext_func_mode(device_t dev)
 	outb(0xaa, port);
 }
 
-void w83627thg_enable_serial(device_t dev, u16 iobase)
-{
-	pnp_enter_ext_func_mode(dev);
-	pnp_set_logical_device(dev);
-	pnp_set_enable(dev, 0);
-	pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
-	pnp_set_enable(dev, 1);
-	pnp_exit_ext_func_mode(dev);
-}
-
 #ifndef __ROMCC__
 void w83627thg_set_clksel_48(device_t dev) {
 	u8 reg8;
diff --git a/src/superio/winbond/w83627thg/w83627thg.h b/src/superio/winbond/w83627thg/w83627thg.h
index a5cc450..ec857d3 100644
--- a/src/superio/winbond/w83627thg/w83627thg.h
+++ b/src/superio/winbond/w83627thg/w83627thg.h
@@ -38,6 +38,5 @@ void pnp_enter_ext_func_mode(device_t dev);
 void pnp_exit_ext_func_mode(device_t dev);
 
 void w83627thg_set_clksel_48(device_t dev);
-void w83627thg_enable_serial(device_t dev, u16 iobase);
 
 #endif /* SUPERIO_WINBOND_W83627THG_W83627THG_H */



More information about the coreboot-gerrit mailing list