[coreboot-gerrit] New patch to review for coreboot: 01a7049 AGESA SPI: Fix Kconfig options

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Tue Apr 29 06:17:27 CEST 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5606

-gerrit

commit 01a70491c69df3b552d47938ddca0d7c2a3c2c93
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Tue Apr 29 07:15:26 2014 +0300

    AGESA SPI: Fix Kconfig options
    
    Option AMD_SB_SPI_LEN leaked to non-AMD configs.
    Option SPI_FLASH is compulsory with HAVE_ACPI_RESUME.
    
    Change-Id: Ib84c4d9e4fdf670b32b0cae7280fcbb6d3aecaf5
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/cpu/amd/agesa/Kconfig                | 1 +
 src/southbridge/amd/Kconfig              | 8 +++++---
 src/southbridge/amd/agesa/hudson/Kconfig | 1 +
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/cpu/amd/agesa/Kconfig b/src/cpu/amd/agesa/Kconfig
index a73c5ce..15ed861 100644
--- a/src/cpu/amd/agesa/Kconfig
+++ b/src/cpu/amd/agesa/Kconfig
@@ -29,6 +29,7 @@ config CPU_AMD_AGESA
 	select TSC_SYNC_LFENCE
 	select UDELAY_LAPIC
 	select LAPIC_MONOTONIC_TIMER
+	select SPI_FLASH if HAVE_ACPI_RESUME
 
 if CPU_AMD_AGESA
 
diff --git a/src/southbridge/amd/Kconfig b/src/southbridge/amd/Kconfig
index 42209ce..39aeb09 100644
--- a/src/southbridge/amd/Kconfig
+++ b/src/southbridge/amd/Kconfig
@@ -15,9 +15,11 @@ source src/southbridge/amd/cimx/Kconfig
 source src/southbridge/amd/agesa/Kconfig
 source src/southbridge/amd/sr5650/Kconfig
 
-config SPI_FLASH
-	bool
-	default y if HAVE_ACPI_RESUME && CPU_AMD_AGESA
+if CPU_AMD_AGESA
+
 config AMD_SB_SPI_TX_LEN
 	int
 	default 4
+	depends on SPI_FLASH
+
+endif
diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig
index dd5120d..9e21b84 100644
--- a/src/southbridge/amd/agesa/hudson/Kconfig
+++ b/src/southbridge/amd/agesa/hudson/Kconfig
@@ -243,6 +243,7 @@ if SOUTHBRIDGE_AMD_AGESA_YANGTZE
 	config AMD_SB_SPI_TX_LEN
 		int
 		default 64
+		depends on SPI_FLASH
 
 	config AZ_PIN
 		hex



More information about the coreboot-gerrit mailing list