[coreboot-gerrit] New patch to review for coreboot: 0fe7501 asrock/e350m1: Sanitize #includes

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Apr 29 12:30:33 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5614

-gerrit

commit 0fe750123d285df21745345067550409270835b4
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Apr 29 20:26:02 2014 +1000

    asrock/e350m1: Sanitize #includes
    
    Following similar reasons as:
    5ff4b08 jetway/nf81-t56n-lf: Sanitize #includes
    
    Change-Id: Ie88b884bc2d4481bc2583d5be1f4d1376547f3c3
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/asrock/e350m1/acpi_tables.c | 11 +++++------
 src/mainboard/asrock/e350m1/mptable.c     | 11 ++++++-----
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/mainboard/asrock/e350m1/acpi_tables.c b/src/mainboard/asrock/e350m1/acpi_tables.c
index 53a2666..c2f90b5 100644
--- a/src/mainboard/asrock/e350m1/acpi_tables.c
+++ b/src/mainboard/asrock/e350m1/acpi_tables.c
@@ -17,17 +17,16 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
-#include <console/console.h>
-#include <string.h>
+#include "agesawrapper.h"
+
 #include <arch/acpi.h>
 #include <arch/acpigen.h>
 #include <arch/ioapic.h>
+#include <console/console.h>
+#include <cpu/amd/amdfam14.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
-#include <cpu/x86/msr.h>
-#include "agesawrapper.h"
-#include <cpu/amd/mtrr.h>
-#include <cpu/amd/amdfam14.h>
+#include <string.h>
 
 extern const unsigned char AmlCode[];
 
diff --git a/src/mainboard/asrock/e350m1/mptable.c b/src/mainboard/asrock/e350m1/mptable.c
index 95df2a6..6444be5 100644
--- a/src/mainboard/asrock/e350m1/mptable.c
+++ b/src/mainboard/asrock/e350m1/mptable.c
@@ -18,14 +18,15 @@
  */
 
 
-#include <console/console.h>
+#include <arch/io.h>
 #include <arch/smp/mpspec.h>
+#include <console/console.h>
+#include <cpu/amd/amdfam14.h>
 #include <device/pci.h>
-#include <arch/io.h>
-#include <string.h>
 #include <stdint.h>
-#include <cpu/amd/amdfam14.h>
-#include <SBPLATFORM.h>
+#include <string.h>
+
+#include <southbridge/amd/cimx/sb800/SBPLATFORM.h>
 
 extern u8 bus_sb800[6];
 



More information about the coreboot-gerrit mailing list