[coreboot-gerrit] New patch to review for coreboot: 2e385b3 console: Move UART port defaults to mainboard

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Tue Apr 29 22:34:23 CEST 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5618

-gerrit

commit 2e385b38a530b66b171b254c15c27c0407793714
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Tue Apr 29 23:27:32 2014 +0300

    console: Move UART port defaults to mainboard
    
    Correct selection of UART depends of board layout, not the CPU
    internals, so default setting should originate from mainboard.
    
    Change-Id: Ibf0ab0847ccce73c22704e86983dbe3d24ebc8a0
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/cpu/allwinner/a10/Kconfig              | 4 ----
 src/cpu/samsung/exynos5250/Kconfig         | 4 ----
 src/cpu/samsung/exynos5420/Kconfig         | 4 ----
 src/mainboard/cubietech/cubieboard/Kconfig | 4 ++++
 src/mainboard/google/pit/Kconfig           | 4 ++++
 src/mainboard/google/snow/Kconfig          | 4 ++++
 6 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/cpu/allwinner/a10/Kconfig b/src/cpu/allwinner/a10/Kconfig
index fbb95a1..a04d8a4 100644
--- a/src/cpu/allwinner/a10/Kconfig
+++ b/src/cpu/allwinner/a10/Kconfig
@@ -71,8 +71,4 @@ config SYS_SDRAM_BASE
 	hex
 	default 0x40000000
 
-config UART_FOR_CONSOLE
-	int
-	default 0
-
 endif # if CPU_ALLWINNER_A10
diff --git a/src/cpu/samsung/exynos5250/Kconfig b/src/cpu/samsung/exynos5250/Kconfig
index 4adc000..86e74a9 100644
--- a/src/cpu/samsung/exynos5250/Kconfig
+++ b/src/cpu/samsung/exynos5250/Kconfig
@@ -87,8 +87,4 @@ config SYS_SDRAM_BASE
 	hex
 	default 0x40000000
 
-config UART_FOR_CONSOLE
-	int
-	default 3
-
 endif
diff --git a/src/cpu/samsung/exynos5420/Kconfig b/src/cpu/samsung/exynos5420/Kconfig
index 3bc7486..8366ea3 100644
--- a/src/cpu/samsung/exynos5420/Kconfig
+++ b/src/cpu/samsung/exynos5420/Kconfig
@@ -89,8 +89,4 @@ config SYS_SDRAM_BASE
 	hex
 	default 0x20000000
 
-config UART_FOR_CONSOLE
-	int
-	default 3
-
 endif
diff --git a/src/mainboard/cubietech/cubieboard/Kconfig b/src/mainboard/cubietech/cubieboard/Kconfig
index 6cb84cf..5c4c1a1 100644
--- a/src/mainboard/cubietech/cubieboard/Kconfig
+++ b/src/mainboard/cubietech/cubieboard/Kconfig
@@ -27,4 +27,8 @@ config DRAM_SIZE_MB
 	int
 	default 1024
 
+config UART_FOR_CONSOLE
+	int
+	default 0
+
 endif # BOARD_CUBIETECH_CUBIEBOARD
diff --git a/src/mainboard/google/pit/Kconfig b/src/mainboard/google/pit/Kconfig
index e7e9a31..cec4e31 100644
--- a/src/mainboard/google/pit/Kconfig
+++ b/src/mainboard/google/pit/Kconfig
@@ -47,4 +47,8 @@ config EC_GOOGLE_CHROMEEC_SPI_BUS
 	hex
 	default 2
 
+config UART_FOR_CONSOLE
+	int
+	default 3
+
 endif # BOARD_GOOGLE_PIT
diff --git a/src/mainboard/google/snow/Kconfig b/src/mainboard/google/snow/Kconfig
index e808eb8..448484d 100644
--- a/src/mainboard/google/snow/Kconfig
+++ b/src/mainboard/google/snow/Kconfig
@@ -52,4 +52,8 @@ config EC_GOOGLE_CHROMEEC_I2C_BUS
 	hex
 	default 4
 
+config UART_FOR_CONSOLE
+	int
+	default 3
+
 endif # BOARD_GOOGLE_SNOW



More information about the coreboot-gerrit mailing list