[coreboot-gerrit] Patch merged into coreboot/master: 2b48b65 northbridge/intel: Out of bounds write to array in gma.h

gerrit at coreboot.org gerrit at coreboot.org
Mon Aug 4 14:01:56 CEST 2014


the following patch was just integrated into master:
commit 2b48b65b1980c4edb6391e4ccf6b1bd8313be944
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Sun Aug 3 23:38:17 2014 +1000

    northbridge/intel: Out of bounds write to array in gma.h
    
    The signature[] array in the mailbox struct opregion_header_t has
    IGD_OPREGION_SIGNATURE written to it with a
    sizeof(IGD_OPREGION_SIGNATURE) and not a sizeof(signature[]). This
    resulted in a silent off-by-one out of bounds illegal write.
    
    Change-Id: I651620a753c743dd2ed2af51c012c27c14a5ea25
    Found-by: Coverity Scan
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Reviewed-on: http://review.coreboot.org/6473
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>


See http://review.coreboot.org/6473 for details.

-gerrit



More information about the coreboot-gerrit mailing list