[coreboot-gerrit] New patch to review for coreboot: 98d4431 falco: Add double function reset to ALC283 verb table

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Thu Aug 7 18:48:19 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6518

-gerrit

commit 98d4431360763e3c93460a3d025fea83a0c013bb
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed Aug 28 09:53:57 2013 -0700

    falco: Add double function reset to ALC283 verb table
    
    The ALC283 needs a double function reset to ensure that all settings
    are reset and the firmware beep is functional.
    
    Original-Change-Id: Id9ddc6f4914957f39c5f9cdfaaac354808929146
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/167291
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Commit-Queue: Duncan Laurie <dlaurie at google.com>
    (cherry picked from commit c59865ac464af308baedcd69aa662f46ff3a04d3)
    
    Change-Id: Ie6f3a8179376bc97a6d22712dd965f5e0e6ec5d6
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/167313
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    (cherry picked from commit b31d7a31b838e67a4b7f33119a3baea049d30a36)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 src/mainboard/google/falco/hda_verb.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/falco/hda_verb.h b/src/mainboard/google/falco/hda_verb.h
index ba0da1c..ae7dbb3 100644
--- a/src/mainboard/google/falco/hda_verb.h
+++ b/src/mainboard/google/falco/hda_verb.h
@@ -21,7 +21,12 @@ static const u32 mainboard_cim_verb_data[] = {
 	/* coreboot specific header */
 	0x10ec0283,	// Codec Vendor / Device ID: Realtek ALC283
 	0x10ec0283,	// Subsystem ID
-	0x0000000c,	// Number of jacks (NID entries)
+	0x0000000d,	// Number of jacks (NID entries)
+
+	0x0017ff00,	// Function Reset
+	0x0017ff00,	// Double Function Reset
+	0x000F0000,	// Pad - get vendor id
+	0x000F0002,	// Pad - get revision id
 
 	/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x10ec0283 */
 	0x00172083,



More information about the coreboot-gerrit mailing list