[coreboot-gerrit] New patch to review for coreboot: 9b1adf6 intel/fsp_bd82x6x: Fix cycle error some more

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Aug 9 19:51:39 CEST 2014


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6569

-gerrit

commit 9b1adf617c9fa45893b9231f9a52be7a066473cf
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat Aug 9 19:50:15 2014 +0200

    intel/fsp_bd82x6x: Fix cycle error some more
    
    As a follow up to #6479 (63e1948643fcbd763c83b6baa6cd9a077d49f1fc),
    fix the remaining faulty loop.
    
    Change-Id: I2c77efe620c71e939f4d74e48f90a166c782e5f5
    Found-by: Coverity Scan
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/southbridge/intel/fsp_bd82x6x/smi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/southbridge/intel/fsp_bd82x6x/smi.c b/src/southbridge/intel/fsp_bd82x6x/smi.c
index 97d0ce4..d035c63 100644
--- a/src/southbridge/intel/fsp_bd82x6x/smi.c
+++ b/src/southbridge/intel/fsp_bd82x6x/smi.c
@@ -132,7 +132,7 @@ static void dump_gpe0_status(u32 gpe0_sts)
 {
 	int i;
 	printk(BIOS_DEBUG, "GPE0_STS: ");
-	for (i=31; i<= 16; i--) {
+	for (i=31; i>= 16; i--) {
 		if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
 	}
 	if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");



More information about the coreboot-gerrit mailing list